Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alert_muting_rule): Add action_on_muting_rule_window_ended attribute in newrelic_alert_muting_rule Terraform Resource #2783

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat(alert_muting_rule): Add action_on_muting_rule_window_ended attribute in newrelic_alert_muting_rule Terraform Resource #2783

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
63f96f3
feat(alert-muting-rule): add end_behaviour attribute to muting rule s…
Aashirwadjain Dec 17, 2024
57456e6
feat(alert-muting-rule): add end_behaviour attribute to create/update…
Aashirwadjain Dec 17, 2024
7ff91ed
feat(alert-muting-rule): add newrelic-client-go commit as dependency …
Aashirwadjain Dec 17, 2024
8e35db1
feat(alert-muting-rule): update end_behaviour attribute to action_on_…
Aashirwadjain Dec 19, 2024
f7a1410
feat(alert-muting-rule): remove expandMutingRuleEndBehaviour and impl…
Aashirwadjain Dec 19, 2024
470f47a
feat(alert-muting-rule): add validation on action_on_muting_rule_wind…
Aashirwadjain Dec 19, 2024
7581c4d
feat(alert-muting-rule): add actionOnMutingRuleWindowEnded attribute …
Aashirwadjain Dec 20, 2024
15800e0
feat(alert-muting-rule): add action_on_muting_rule_window_ended attri…
Aashirwadjain Dec 20, 2024
c25bc36
feat(alert-muting-rule): add example usage for action_on_muting_rule_…
Aashirwadjain Dec 20, 2024
a5c696c
feat(alert-muting-rule): add actionOnMutingRuleWindowEnded to testAcc…
Aashirwadjain Dec 20, 2024
f62a74b
feat(alert-muting-rule): add TestAccNewRelicAlertMutingRule_EndBehavi…
Aashirwadjain Dec 20, 2024
e3a9b3e
feat(alert-muting-rule): update validation on action_on_muting_rule_w…
Aashirwadjain Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions newrelic/resource_newrelic_alert_muting_rule.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ func resourceNewRelicAlertMutingRule() *schema.Resource {
"action_on_muting_rule_window_ended": {
Type: schema.TypeString,
Optional: true,
Computed: true,
Description: "The action when the muting rule window is ended or disabled.",
ValidateFunc: validation.StringInSlice(
[]string{
Expand Down
5 changes: 1 addition & 4 deletions newrelic/structures_newrelic_alert_muting_rule.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,10 +278,7 @@ func flattenMutingRule(mutingRule *alerts.MutingRule, d *schema.ResourceData) er
configuredCondition := x.([]interface{})

_ = d.Set("enabled", mutingRule.Enabled)

if _, ok := d.GetOk("action_on_muting_rule_window_ended"); ok {
_ = d.Set("action_on_muting_rule_window_ended", mutingRule.ActionOnMutingRuleWindowEnded)
}
_ = d.Set("action_on_muting_rule_window_ended", mutingRule.ActionOnMutingRuleWindowEnded)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagrawal-newrelic @Aashirwadjain this is nice, but the attribute doesn't need to be Computed for this to happen since the read function is anyway being called in create; you can just have this condition.

The only thing to double check is that since this is coming from an enum in client go, if there is no value returned from the API for this attribute, is an empty string effectively being sent to Terraform from the Go Client via this attribute and saved as "" to the state; if this is the case, we should be okay; and if not, a condition might need to be added accordingly. I don't think this should be the case though.

Please test these changes (for all cases we ideated previously) and let me know if you discover something unusual


err := d.Set("condition", flattenMutingRuleConditionGroup(mutingRule.Condition, configuredCondition))
if err != nil {
Expand Down
Loading