feat(alert_muting_rule): Add action_on_muting_rule_window_ended attribute in newrelic_alert_muting_rule Terraform Resource

[Aashirwadjain]

Description

• The addition of the action_on_muting_rule_window_ended attribute in the newrelic_alert_muting_rule Terraform resource aims to enhance the functionality of muting rules within New Relic's alerting system using terraform.
• The attribute action_on_muting_rule_window_ended is added to MutingRule Schema Resource and handler methods.
• Link to GitHub Issue: Resource newrelic_alert_muting_rule: Support for Muting Rule "End Behaviour" #2774

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

Please delete options that are not relevant.

• My commit message follows conventional commits
• My code is formatted to Go standards
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

[vagrawal-newrelic]

approved

[pranav-new-relic]

@Aashirwadjain please add documentation changes (I've pointed where the documentation is to be added below), without which customers would not be aware of the addition of this new attribute.

terraform-provider-newrelic/website/docs/r/alert_muting_rule.html.markdown

Lines 48 to 57 in 25894e4

	## Argument Reference
	The following arguments are supported:
	* `account_id` - (Optional) The account id of the MutingRule.
	* `condition` - (Required) The condition that defines which incidents to target. See [Nested condition blocks](#nested-condition-blocks) below for details.
	* `enabled` - (Required) Whether the MutingRule is enabled.
	* `name` - The name of the MutingRule.
	* `description` - The description of the MutingRule.
	* `schedule` - (Optional) Specify a schedule for enabling the MutingRule. See [Schedule](#schedule) below for details

[pranav-new-relic]

@Aashirwadjain in addition, please add relevant changes to integration tests, to make sure this new attribute is also part of the configuration that is created, read, and updated by the integration test for muting rules.

Please see the following file, add wherever appropriate. By this, I mean - you don't have to add the attribute to all tests, just make sure the attribute is added wherever needed to make sure atleast one test fully covers this attribute too, along with other attributes of the resource (during create, read, update).

terraform-provider-newrelic/newrelic/resource_newrelic_alert_muting_rule_test.go

Line 3 in 25894e4

[pranav-new-relic]

@Aashirwadjain one occurrence that you will also find while testing your changes :)

Screen.Recording.2024-12-19.at.12.18.13.AM.mov

• compile your local changes and try using a configuration of the resource newrelic_alert_muting_rule, but without the new attribute you've added. Perform a terraform plan and terraform apply to create a brand new muting rule.
• immediately after the above, run a terraform plan. Since no external changes were made in the UI, or in the Terraform configuration, the expectation of this terraform plan would be a "no changes" output, but you see a that a drift is being shown, of a change that the customer did not make, with regard to this new attribute.

Think of why this is happening, and what needs to be added/deleted/fixed in the code to prevent this occurrence. Fixing this is important, otherwise this would affect current customers using this Terraform resource without the new attribute (if these changes are merged without the fix, they would see a change upon terraform plan they did not make, or have no idea about).

Please rigorously test your changes to help fill such gaps :)

[Aashirwadjain]

Thanks for suggestions @pranav-new-relic, Following changes are made accordingly:

• Documentation is updated and added description of action_on_muting_rule_window_ended attribute.
• action_on_muting_rule_window_ended attribute is added to integration tests.
• flattenMutingRule method is updated and added validations.

[pranav-new-relic]

[pranav-new-relic]

@vagrawal-newrelic @Aashirwadjain this is nice, but the attribute doesn't need to be Computed for this to happen since the read function is anyway being called in create; you can just have this condition.

The only thing to double check is that since this is coming from an enum in client go, if there is no value returned from the API for this attribute, is an empty string effectively being sent to Terraform from the Go Client via this attribute and saved as "" to the state; if this is the case, we should be okay; and if not, a condition might need to be added accordingly. I don't think this should be the case though.

Please test these changes (for all cases we ideated previously) and let me know if you discover something unusual

[pranav-new-relic]

Suggested change

	* `action_on_muting_rule_window_ended` - (Optional) The action when the muting rule window is ended or disabled. Valid values are `CLOSE_ISSUES_ON_INACTIVE`, `DO_NOTHING`
	* `action_on_muting_rule_window_ended` - (Optional) The action when the muting rule window is ended or disabled. Valid values are `CLOSE_ISSUES_ON_INACTIVE`, `DO_NOTHING`.

just a . :)

[pranav-new-relic]

we should be good to merge once the requested changes are done (and further reviewed by VIshal/me), but ⚠️

• after the freeze
• after Rohan's PR refactor(gcp-link-account): Refactor GCP integration resource for readability #2785 is merged
• after the Go Client with these changes feat(alert_muting_rule): Add action_on_muting_rule_window_ended attribute in newrelic_alert_muting_rule Terraform Resource newrelic-client-go#1259 is released, and go.mod in this PR is updated with the corresponding release version of the Go Client containing those changes