Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update transformer version to <4.40 #2204

Merged
merged 12 commits into from
Apr 3, 2024
Merged

Update transformer version to <4.40 #2204

merged 12 commits into from
Apr 3, 2024

Conversation

dbogunowicz
Copy link
Contributor

@dbogunowicz dbogunowicz commented Mar 29, 2024 •
edited
Loading

Changelog:

  • support for transformers<4.40
  • update the forward methods in the modify... scripts in sparseml.transformers.sparsification.modification, to be compatible with the latest transformers version
  • renaming SiLUActivation to SiLU in sample recipes
  • removing the deprecated use_cuda_amp argument and ShardedDDPOption class

@dbogunowicz dbogunowicz mentioned this pull request Mar 29, 2024
Closed
8 tasks
Base automatically changed from feature/damian/forkless_4.34 to main March 29, 2024 14:33
@dbogunowicz dbogunowicz changed the title [WiP] Update transformer version to <4.40 Update transformer version to <4.40 Apr 2, 2024
@dbogunowicz dbogunowicz requested review from bfineran, mgoin and Satrat April 2, 2024 12:20
@dbogunowicz dbogunowicz force-pushed the feature/damian/update_transformers branch from 76d5d2e to ddb5ea1 Compare April 2, 2024 12:39
mgoin
mgoin reviewed Apr 2, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@dbogunowicz dbogunowicz requested a review from mgoin April 3, 2024 10:49
@bfineran bfineran mentioned this pull request Apr 3, 2024
Merged
@robertgshaw2-neuralmagic
Copy link
Contributor

This can be a follow up PR

But - what do we think about having an alias internally for SiLU such that older recipes do not break?

@dbogunowicz dbogunowicz merged commit 8ba1dba into main Apr 3, 2024
13 of 15 checks passed
@dbogunowicz dbogunowicz deleted the feature/damian/update_transformers branch April 3, 2024 15:54
@mgoin mgoin mentioned this pull request Apr 3, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfineran bfineran bfineran approved these changes

@mgoin mgoin mgoin approved these changes

@Satrat Satrat Awaiting requested review from Satrat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbogunowicz @robertgshaw2-neuralmagic @mgoin @bfineran