[Quantization] Add alias mapping for target types (fixes SiLU name change issue) #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dbogunowicz to revert test patches in #2204 to test this PR |
mgoin
previously approved these changes
Apr 3, 2024
dbogunowicz
previously approved these changes
Apr 3, 2024
There was a problem hiding this comment.
@bfineran LGTM; testing confirms that. Let's hodl off with landing this patch as proposed during our call and wait for the parent PR to land first.
dbogunowicz
dismissed stale reviews from mgoin and themself
The base branch was changed.
dbogunowicz
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transformers recently updated usage of
SiLUto theSiLUActivationclass. When upgrading transformers this will cause backwards compatibility issues with existing recipes.This PR proposes a fix by adding class alias support in quantization modifier name matching. Any reference to
SiLUin a recipe will now also check forSiLUActivationtest_plan:
@dbogunowicz to revert test patches in #2204 to test this PR