Forkless transformers [4.34.1] #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoin
reviewed
Mar 28, 2024
src/sparseml/transformers/sparsification/modification/modify_model.py
Outdated
Show resolved
Hide resolved
| symmetric: False""" | ||
|
|
||
|
|
||
| def test_modifying_llama(llama_model, shared_helper_functions): |
There was a problem hiding this comment.
We should get to the point where we can test making a modified model and an unmodified model, and then run through them comparing outputs. This may help catch the forward passes changing between transformers versions. This may be too intensive for current hardware, but I think should absolutely be setup with the gpu runners - thoughts?
There was a problem hiding this comment.
Good idea. This is a big step toward robust detection of problems that arise from the transformers upgrade.
…/sparseml into feature/damian/forkless_4.34
dbogunowicz
commented
Mar 29, 2024
dbogunowicz
commented
Mar 29, 2024
8 tasks
mgoin
previously approved these changes
Mar 29, 2024
Co-authored-by: Michael Goin <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A copy of this PR: #2046, but instead of introducing
transformers<3.37, we installtransformers==3.34.1. This is the same transformer version as in our fork.