Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix https://github.com/nestjs/nest-cli/issues/1995 #1997

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix https://github.com/nestjs/nest-cli/issues/1995 #1997

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47b9b4e
close compiler so that webpack cache will save on filesystem
hkjeffchan Mar 21, 2023
46b8ee0
Merge branch 'nestjs:master' into master
hkjeffchan Mar 21, 2023
aecb3ea
fix to not close compiler if watch mode
hkjeffchan Mar 22, 2023
9a16053
Merge branch 'master' of https://github.com/hkjeffchan/nest-cli
hkjeffchan Mar 22, 2023
e01a6db
Merge branch 'nestjs:master' into master
hkjeffchan Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/compiler/webpack-compiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,9 @@ export class WebpackCompiler {
return process.exit(1);
}
console.log(statsOutput);
if (!watchMode && !watch) {
compiler.close(() => {});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we move this up - above the process.exit()?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it won't run... we need to move inside "!err && !stats.hasErrors()"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or just leave it here at line 143

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

      if (!err && !stats!.hasErrors()) {
        if (!onSuccess) {
          assetsManager.closeWatchers();
        } else {
          onSuccess();
        }
      } else if (!watchMode && !watch) {
        console.log(statsOutput);
        return process.exit(1);
      }
      console.log(statsOutput);
      if (!watchMode && !watch) {
        compiler.close(() => {});
      }

or

      if (!err && !stats!.hasErrors()) {
        if (!onSuccess) {
          assetsManager.closeWatchers();
        } else {
          onSuccess();
        }
        if (!watchMode && !watch) {
          compiler.close(() => {});
        }
      } else if (!watchMode && !watch) {
        console.log(statsOutput);
        return process.exit(1);
      }

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamilmysliwiec

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamilmysliwiec Would you check if you can merge this now?

}
};

if (watchMode || watch) {
Expand Down