-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix https://github.com/nestjs/nest-cli/issues/1995 #1997
base: master
Are you sure you want to change the base?
Conversation
Updated the PR. |
@@ -140,6 +140,9 @@ export class WebpackCompiler { | |||
return process.exit(1); | |||
} | |||
console.log(statsOutput); | |||
if (!watchMode && !watch) { | |||
compiler.close(() => {}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we move this up - above the process.exit()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it won't run... we need to move inside "!err && !stats.hasErrors()"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or just leave it here at line 143
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!err && !stats!.hasErrors()) {
if (!onSuccess) {
assetsManager.closeWatchers();
} else {
onSuccess();
}
} else if (!watchMode && !watch) {
console.log(statsOutput);
return process.exit(1);
}
console.log(statsOutput);
if (!watchMode && !watch) {
compiler.close(() => {});
}
or
if (!err && !stats!.hasErrors()) {
if (!onSuccess) {
assetsManager.closeWatchers();
} else {
onSuccess();
}
if (!watchMode && !watch) {
compiler.close(() => {});
}
} else if (!watchMode && !watch) {
console.log(statsOutput);
return process.exit(1);
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kamilmysliwiec Would you check if you can merge this now?
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
webpack cache is not created using
nest build
if cache is set in webpack.config.jsIssue Number: 1995
What is the new behavior?
webpack cache is created using
nest build
if cache is set in webpack.config.jsDoes this PR introduce a breaking change?
Other information