Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: friendly error messages, add review comment output #374

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat: friendly error messages, add review comment output #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c8eb07e
handle errors, add review comment output
mtfoley Aug 24, 2023
2220180
handle blank comment case
mtfoley Aug 24, 2023
a1c8a60
update readme
mtfoley Aug 24, 2023
7c584a4
maintain original error context
mtfoley Aug 25, 2023
e776fc1
debug some things
mtfoley Aug 27, 2023
df2d145
debug some more things
mtfoley Aug 27, 2023
a135e35
debug payloads
mtfoley Aug 27, 2023
0a21b47
gotta compile it, matt
mtfoley Aug 27, 2023
f2832b7
needed else, omg
mtfoley Aug 27, 2023
fd362c7
debug label errors
mtfoley Aug 27, 2023
2b51bb7
control flow things
mtfoley Aug 27, 2023
d6e5d83
merge from main
mtfoley Sep 10, 2023
f4dfad1
Merge branch 'main' of github.com:mtfoley/pr-compliance-action into o…
mtfoley Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,3 +96,4 @@ body-check | Result of match for PR Body against configured regex.
branch-check | Result of check to ensure PR head is not protected branch.
title-check | Result of check to ensure PR title is formatted per [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/)
watch-files-check | Result of check for watched files having been modified. True if no modifications found to watched files.
review-comment | The pull request review comment that the action will attempt to create/update.
2 changes: 2 additions & 0 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,8 @@ outputs:
description: 'Result of check to ensure PR title is formatted per [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/)'
watch-files-check:
description: 'Result of check for watched files having been modified. True if no modifications found to watched files.'
review-comment:
description: 'Pull request review comment that the action will attempt to create/update.'
runs:
using: 'node16'
main: 'dist/index.js'
Loading
Loading