feat: friendly error messages, add review comment output #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main.ts
Outdated
| state: 'closed' | ||
| }) | ||
| } catch (error) { | ||
| if (error instanceof Error) throw new Error(errors.closingPullRequest) |
There was a problem hiding this comment.
I think we'd want to somehow log the original error regardless.
There was a problem hiding this comment.
new commit just dropped - still haven't smoke tested, buyer beware
3 tasks
|
👋 ping @mtfoley - is there anything I can do to help here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Adds try/catch blocks around octokit REST api calls to allow friendly error messages.
Adds new output for "review-comment" that will be set whenever the review comment body is known.
Related Tickets & Documents
Resolves #368
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?