Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subframe tutorial #81

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

vatanaksoytezer
Copy link
Contributor

@vatanaksoytezer vatanaksoytezer commented Apr 27, 2021

  • Add subframe tutorial
  • Add resolve contraint frames to other tutorials, (so if people want to use subframes from those tutorials it would work)

Currently blocked by moveit/moveit_resources#64

@vatanaksoytezer vatanaksoytezer changed the title WIP: Add subframe tutorial Add subframe tutorial Apr 27, 2021
@vatanaksoytezer vatanaksoytezer changed the title Add subframe tutorial WIP: Add subframe tutorial Apr 28, 2021
@vatanaksoytezer vatanaksoytezer changed the title WIP: Add subframe tutorial Add subframe tutorial Apr 28, 2021
@vatanaksoytezer vatanaksoytezer linked an issue Apr 29, 2021 that may be closed by this pull request

In the second terminal run the tutorial: ::

rosrun moveit_tutorials subframes_tutorial
ros2 launch moveit2_tutorials subframes_tutorial.launch.py

In this terminal you should be able to enter numbers from 1-12 to send commands, and to see how the robot and the scene react.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 46 below should be moveit2_tutorials.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixing it.

Copy link
Contributor

@MarqRazz MarqRazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built, ran the demo and generated the webpage.

Small things I noticed...
This demo also suffers from this bug
I get errors saying the move is timing out every once in a while (someone testing calibration with the Panda robot was saying they were have the same issue)
image

[ros2_control_node-5] [panda_arm_controller]: Goal reached, success!
[move_group-4] [moveit.simple_controller_manager.follow_joint_trajectory_controller_handle]: waitForExecution timed out
[move_group-4] [moveit_ros.trajectory_execution_manager]: Controller is taking too long to execute trajectory (the expected upper bound for the trajectory execution was 3.738405 seconds). Stopping trajectory.
[move_group-4] [moveit.simple_controller_manager.follow_joint_trajectory_controller_handle]: Cancelling execution for panda_arm_controller
[ros2_control_node-5] [panda_arm_controller]: Got request to cancel goal
[move_group-4] [moveit_ros.trajectory_execution_manager]: Completed trajectory execution with status TIMED_OUT ...
[move_group-4] [moveit_move_group_default_capabilities.execute_trajectory_action_capability]: Execution completed: TIMED_OUT

@vatanaksoytezer
Copy link
Contributor Author

This demo also suffers from this bug

This is correct. Anything using move_group with and attached object is effected.

I get errors saying the move is timing out every once in a while (someone testing calibration with the Panda robot was saying they were have the same issue)

In the case that you get these errors. Is the tutorial still working or not?

@MarqRazz
Copy link
Contributor

MarqRazz commented May 5, 2021

Everything works as expected, except for the message printing.

@vatanaksoytezer
Copy link
Contributor Author

Everything works as expected, except for the message printing.

I will have a look and try to understand what happens

@MarqRazz
Copy link
Contributor

Today I updated all of my moveit repos and tried to test this branch again and it is seg faulting when I run this demo. I double checked to make sure default_planner_request_adapters/ResolveConstraintFrames was listed in ompl_planning_pipeline.launch.xml and it is but not in the recommended order that is suggested in the Troubleshooting section. Changing the order didnt help so I will keep digging for the issue...

[ERROR] [move_group-4]: process has died [pid 221215, exit code -11, cmd '/home/marq/moveit_ws/install/moveit_ros_move_group/lib/moveit_ros_move_group/move_group --ros-args --params-file /tmp/launch_params_ta9prs0_ --params-file /tmp/launch_params_4lmt_ds2 --params-file /tmp/launch_params_rpy3poyd --params-file /tmp/launch_params_yt8jqzwb --params-file /tmp/launch_params_8j_mcseo --params-file /tmp/launch_params_sg8szb1i --params-file /tmp/launch_params_z_jhxddx'].

@vatanaksoytezer
Copy link
Contributor Author

Today I updated all of my moveit repos and tried to test this branch again and it is seg faulting when I run this demo. I double checked to make sure default_planner_request_adapters/ResolveConstraintFrames was listed in ompl_planning_pipeline.launch.xml and it is but not in the recommended order that is suggested in the Troubleshooting section. Changing the order didnt help so I will keep digging for the issue...

Thanks for digging in @MarqRazz I'll also have a look soon. I completely forgot this existed lol

@mergify
Copy link

mergify bot commented Jan 13, 2022

This pull request is in conflict. Could you fix it @vatanaksoytezer?

@davetcoleman
Copy link
Member

@vatanaksoytezer this PR is over a year old, is it still relevant?

@vatanaksoytezer
Copy link
Contributor Author

Same with #80.

@mergify
Copy link

mergify bot commented Sep 26, 2022

This pull request is in conflict. Could you fix it @vatanaksoytezer?

4 similar comments
@mergify
Copy link

mergify bot commented Apr 2, 2023

This pull request is in conflict. Could you fix it @vatanaksoytezer?

@mergify
Copy link

mergify bot commented Jul 18, 2023

This pull request is in conflict. Could you fix it @vatanaksoytezer?

@mergify
Copy link

mergify bot commented Aug 14, 2023

This pull request is in conflict. Could you fix it @vatanaksoytezer?

Copy link

mergify bot commented Dec 15, 2023

This pull request is in conflict. Could you fix it @vatanaksoytezer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port "Subframes" tutorial
3 participants