Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to phpcs 3.10.1 #162

Merged
merged 1 commit into from
May 28, 2024
Merged

Bump to phpcs 3.10.1 #162

merged 1 commit into from
May 28, 2024

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented May 20, 2024

And also to current dev phpcompatibility 96072c30

@andrewnicols
Copy link
Contributor

I was goign to merge this but 3.10.1 has been released and fixes at least one regression introduced in 3.10.0.

@stronk7
Copy link
Member Author

stronk7 commented May 28, 2024

Yep, saw it yesterday, will bump this soon. Thanks!

And also to current dev phpcompatibility 96072c30
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.90%. Comparing base (4d16f38) to head (dd07083).

Current head dd07083 differs from pull request most recent head b56aaf0

Please upload reports for the commit b56aaf0 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #162   +/-   ##
=========================================
  Coverage     97.90%   97.90%           
  Complexity      850      850           
=========================================
  Files            37       37           
  Lines          2524     2524           
=========================================
  Hits           2471     2471           
  Misses           53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stronk7 stronk7 changed the title Bump to phpcs 3.10.0 Bump to phpcs 3.10.1 May 28, 2024
@stronk7
Copy link
Member Author

stronk7 commented May 28, 2024

Done, now it's using 3.10.1.

@andrewnicols andrewnicols merged commit c9b7667 into moodlehq:main May 28, 2024
11 checks passed
@stronk7 stronk7 deleted the phpcs_3_10 branch May 28, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants