New sniff to detect correct setUp/tearDown parent calls #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the results when executing it against core (4.5dev). 492 cases detected and fixed. Ciao :-) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
============================================
+ Coverage 97.93% 97.99% +0.06%
- Complexity 860 886 +26
============================================
Files 38 39 +1
Lines 2564 2647 +83
============================================
+ Hits 2511 2594 +83
Misses 53 53 ☔ View full report in Codecov by Sentry. |
stronk7
force-pushed
the
setup_teardown_parent
branch
5 times, most recently
from
87cd2e6
to
a1d52e9
Compare
It detects various situations like: - Missing calls to parent. - Dupe calls. - Incorrect calls. And, when possible, tries to fix the missing ones (not others) by adding them in a correct place: - For setUp cases, at the beginning of the method. - For tearDown cases, at the end of the method. Of course, covered with tests. Fixes moodlehq#106
stronk7
force-pushed
the
setup_teardown_parent
branch
from
a1d52e9
to
6a458cb
Compare
andrewnicols
requested changes
May 30, 2024
stronk7
referenced
this pull request
in andrewnicols/moodle-cs
May 31, 2024
|
Thanks @andrewnicols , I've cherry-picked your commit here, and applied a few small (comments, problem cases) modifications to it, to better understand what's going with those empty methods. I think this now is perfect! 😎 |
andrewnicols
approved these changes
May 31, 2024
andrewnicols
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It detects various situations like:
And, when possible, tries to fix the missing ones (not others) by adding them in a correct place:
Only for 405 and above.
Of course, covered with tests.
Fixes #106
Note that this is built on top of #162.