-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
normalize vector data to a standard form during insertion (#27469) #2322
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CaoHaiNam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @CaoHaiNam! It looks like this is your first PR to milvus-io/pymilvus 🎉 |
f77c27a
to
b580349
Compare
b580349
to
1c674fe
Compare
7b63170
to
1e01b72
Compare
16aa645
to
6f8463d
Compare
@XuanYang-cn @longjiquan @wangting0128 For this PR, please focus on the following four files where I made changes:
Thank you for your understanding, and I appreciate your patience. |
@CaoHaiNam This PR involved too many changes and commits from other PRs, please rebase you branch to the latest pymilvus master and narrow down to contain your changes only, THX |
I think a simple git rebase should fix the problem. |
I got it, THX. |
Signed-off-by: NamCaoHai <[email protected]>
Signed-off-by: NamCaoHai <[email protected]>
Signed-off-by: NamCaoHai <[email protected]>
Signed-off-by: NamCaoHai <[email protected]>
6f8463d
to
9517303
Compare
Signed-off-by: NamCaoHai <[email protected]>
@XuanYang-cn I have finished the updates. Could you please review my pull request again? Thank you. |
@XuanYang-cn Hi, just a quick follow-up on this pull request. I would appreciate any feedback or updates on the review status. Please let me know if there's anything I need to adjust. Thank you. |
Signed-off-by: NamCaoHai <[email protected]>
This pull request handle Normalization function mentioned here milvus-io/milvus/#27469
Run:
examples/example_normalization_fields.py
to evaluate my pull request.