Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the too long default root password does not take effect #37983

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix: the too long default root password does not take effect #37983

merged 1 commit into from
Nov 26, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Nov 25, 2024

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 25, 2024

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Nov 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (27c22d1) to head (9b30460).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
internal/rootcoord/root_coord.go 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37983       +/-   ##
===========================================
+ Coverage   68.87%   81.03%   +12.15%     
===========================================
  Files         289     1360     +1071     
  Lines       25481   190783   +165302     
===========================================
+ Hits        17551   154608   +137057     
- Misses       7930    30672    +22742     
- Partials        0     5503     +5503
Components Coverage Δ
Client 72.33% <ø> (∅)
Core 68.87% <ø> (ø)
Go 83.20% <75.00%> (∅)
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.36% <100.00%> (ø)
internal/rootcoord/root_coord.go 89.41% <42.85%> (ø)

... and 1069 files with indirect coverage changes

@SimFG
Copy link
Contributor Author

SimFG commented Nov 25, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 25, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 25, 2024

rerun go-sdk

@SimFG
Copy link
Contributor Author

SimFG commented Nov 25, 2024

/run-cpu-e2e

1 similar comment
@SimFG
Copy link
Contributor Author

SimFG commented Nov 25, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 25, 2024

rerun go-sdk

@SimFG
Copy link
Contributor Author

SimFG commented Nov 25, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 26, 2024

/run-cpu-e2e

@SimFG
Copy link
Contributor Author

SimFG commented Nov 26, 2024

rerun go-sdk

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Nov 26, 2024
@sre-ci-robot sre-ci-robot merged commit 2208b7c into milvus-io:master Nov 26, 2024
19 of 20 checks passed
JsDove pushed a commit to JsDove/milvus that referenced this pull request Nov 26, 2024
@SimFG @JsDove
fix: the too long default root password does not take effect (milvus-…
ceca0ff 
…io#37983)

- issue: milvus-io#36987

Signed-off-by: SimFG <[email protected]>
This was referenced Dec 2, 2024
Closed
Merged
sre-ci-robot pushed a commit that referenced this pull request Dec 13, 2024
@SimFG
enhance: [2.4] pick some master improvements to 2.4 branch (#38128)
df73f93 
- issue: #38127

master pr list:
- #37759
- #37835
- #37845
- #37874
- #37894
- #37969
- #37983
- #38005
- #38035

---------

Signed-off-by: SimFG <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@xiaofan-luan xiaofan-luan

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimFG @xiaofan-luan @sre-ci-robot