Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the keyboard navigation plugin support #9904

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Fix the keyboard navigation plugin support #9904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f03a3b7
fix keyboard nav
riknoll Mar 4, 2024
d4192be
fix focus for text dropdown
riknoll Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pxtblocks/fields/field_textdropdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export class BaseFieldTextDropdown extends Blockly.FieldTextInput {
// Focusing needs to be handled after the menu is rendered and positioned.
// Otherwise it will cause a page scroll to get the misplaced menu in
// view. See issue #1329.
this.menu_!.focus();
// this.menu_!.focus();

if (this.selectedMenuItem) {
this.menu_!.setHighlighted(this.selectedMenuItem);
Expand Down
2 changes: 2 additions & 0 deletions pxtblocks/plugins/flyout/verticalFlyout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ export class VerticalFlyout implements Blockly.IFlyout {
return this.element;
}

this.dummyWorkspace.createDom();

this.element = Blockly.utils.dom.createSvgElement(
tagName,
{
Expand Down
2 changes: 1 addition & 1 deletion webapp/src/blocks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ export class Editor extends toolboxeditor.ToolboxEditor {
pxtblockly.FIELD_EDITOR_OPEN_EVENT_TYPE
];

if (ev.type !== "var_create") {
if (ev.type !== "var_create" && ev.type !== "marker_move") {
this.hideFlyout();
}

Expand Down