Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the keyboard navigation plugin support #9904

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Fix the keyboard navigation plugin support #9904

merged 2 commits into from
Mar 4, 2024

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Mar 4, 2024

Fixing our keyboard navigation. Three small bugs:

  1. The dummy workspace was never initialized in the multi-flyout and caused an exception during init
  2. We were immediately closing the flyout when the cursor moved because of the workspace event being fired
  3. The dropdown portion of the text dropdown field was being focused, which broke typing into the field.

@riknoll riknoll requested a review from a team March 4, 2024 23:26
eanders-ms
eanders-ms approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@eanders-ms eanders-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@riknoll riknoll merged commit af96f25 into master Mar 4, 2024
7 checks passed
@riknoll riknoll deleted the dev/riknoll/fix-keyboard-nav branch March 4, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eanders-ms eanders-ms eanders-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riknoll @eanders-ms