Teacher tool: added two simple variable validator rules #9859
Conversation
…erk-variable-validation
| { | ||
| "validator": "blocksExist", | ||
| "blockCounts": { | ||
| "variables_set": 1 |
There was a problem hiding this comment.
We may want to add an additional check here for variables_change, which will also work as a set in some cases (but keep threshold as 1).
There was a problem hiding this comment.
I would prefer to keep that as a separate check and wait for feedback on it. It makes sense that we assign a variable a value when the variable is created so there are less errors. However, allowing a variables_change to act as a setter in a validation scenario feels like a dangerous thing to allow. The act of distinctively setting a variable value is a pretty important learning point for computer science.
There was a problem hiding this comment.
I can add a validator for variables_change, too, though.
There was a problem hiding this comment.
Hm, I don't think we need to add a whole separate validator for it. Feel free to leave as-is for now.
There was a problem hiding this comment.
Validating that the program changes the value of a variable is actually non-trivial, since both "change" or "set" could do it, but "set" would have to be called twice on the same variable to achieve the intuitive result, which might be tricky to check. I'd only go down that rabbit hole if we get feedback asking for it.
There was a problem hiding this comment.
Sounds good. I'll leave as is, then. Will definitely want to revisit the "variable changed" validation in the future.
Co-authored-by: Thomas Sparks <[email protected]>
I added these just really quick to have a quick validator for variables_set and variables_get, as a variable validator will be important for rubrics for tutorials. I think they might need to be a bit more nuanced than this, but it's a start.