Teacher tool: added two simple variable validator rules (#9859)

* add simple variable validator * Update catalog template to custom variable Co-authored-by: Thomas Sparks <[email protected]> --------- Co-authored-by: Thomas Sparks <[email protected]>
microsoft · Feb 8, 2024 · 5cc8bc3 · 5cc8bc3
1 parent 249d5fa
commit 5cc8bc3
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 0 deletions.
diff --git a/docs/teachertool/catalog-shared.json b/docs/teachertool/catalog-shared.json
@@ -23,6 +23,18 @@
             "use": "functions_have_comments",
             "template": "All function definitions have comments",
             "docPath": "/teachertool"
+        },
+        {
+            "id": "D21D76A2-D9FD-4F9B-B0AC-973CB870EA78",
+            "use": "variable_set",
+            "template": "At least one custom variable is set",
+            "docPath": "/teachertool"
+        },
+        {
+            "id": "0173898D-8A48-4266-AAB9-CE934471A734",
+            "use": "variable_accessed",
+            "template": "At least one variable is accessed",
+            "docPath": "/teachertool"
         }
     ]
 }
diff --git a/docs/teachertool/validator-plans-shared.json b/docs/teachertool/validator-plans-shared.json
@@ -70,6 +70,32 @@
                     }
                 }
             ]
+        },
+        {
+            ".desc": "A variable's value is set",
+            "name": "variable_set",
+            "threshold": 1,
+            "checks": [
+                {
+                    "validator": "blocksExist",
+                    "blockCounts": {
+                        "variables_set": 1
+                    }
+                }
+            ]
+        },
+        {
+            ".desc": "A variable's value is used",
+            "name": "variable_accessed",
+            "threshold": 1,
+            "checks": [
+                {
+                    "validator": "blocksExist",
+                    "blockCounts": {
+                        "variables_get": 1
+                    }
+                }
+            ]
         }
     ]
 }