localization for webusb connection failed msg #9688
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: microsoft/pxt-microbit#5357
The extension labels would need to be extracted from
targetconfig.json
and uploaded at build time (along with anrlf
if that isn't already there). We do similar things here https://github.com/microsoft/pxt/blob/master/cli/cli.ts#L1852 for gallery, so it'd be walking through all approved extensions, aggregating list of labels, and including in translation. Maybe worth considering packaging in translations fortargetConfig.multiplayer.games[?].title
as well (suggestion cards underneath multiplayer host screen), since those aren't translatable either right now