Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localization for webusb connection failed msg #9688

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

jwunderl
Copy link
Member

re: microsoft/pxt-microbit#5357

The extension labels would need to be extracted from targetconfig.json and uploaded at build time (along with an rlf if that isn't already there). We do similar things here https://github.com/microsoft/pxt/blob/master/cli/cli.ts#L1852 for gallery, so it'd be walking through all approved extensions, aggregating list of labels, and including in translation. Maybe worth considering packaging in translations for targetConfig.multiplayer.games[?].title as well (suggestion cards underneath multiplayer host screen), since those aren't translatable either right now

@jwunderl jwunderl requested a review from a team September 19, 2023 16:59
Copy link
Contributor

@srietkerk srietkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! For the extensions label part, do we want to make a new issue or are we just going to continue to reference the issue that you linked?

@jwunderl
Copy link
Member Author

I'm not closing that one with this pr so probably fine to leave it on that one :) Normally I'd just fix it just timing with a vacation / other things to do / bleh

@jwunderl jwunderl merged commit 867fd79 into master Sep 19, 2023
7 checks passed
@jwunderl jwunderl deleted the jwunderl-patch-2 branch September 19, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants