port hardware options to targetconfig #6089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abchatra
approved these changes
Sep 26, 2023
jwunderl
added a commit
that referenced
this pull request
Oct 5, 2023
* port hardware options to targetconfig * add variant for micro:bit shield entries, reorder based off usage
jwunderl
added a commit
that referenced
this pull request
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duped content from https://github.com/microsoft/pxt-arcade/blob/master/docs/hardware.md, we want to avoid having dep on markdown page / just targetconfig.
RE: #6070
localization will need to be handled similar to microsoft/pxt#9688, but that's fine / easier to explain than the json in md that currently exists.