Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add help button for how to pop out video in firefox #9298

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

jwunderl
Copy link
Member

Possible quick fix for microsoft/pxt-arcade#5490, since firefox doesn't support picture in picture api / have there own way to do it.

image

We'd have to write a quick markdown page at /firefox-picture-in-picture which I didn't do, but would likely largely be similar to https://support.mozilla.org/en-US/kb/about-picture-picture-firefox

@thsparks
Copy link
Contributor

LGTM, but should we wait until we have the docs to check in?

@kiki-lee
Copy link
Contributor

Could we do an anigif to quickly show how instead? Something that appears in a div when you click that button?

@abchatra
Copy link
Collaborator

Primary object for the students is to watch the video and popping out is secondary action only if required. This long text makes me think, students will try to click or play with the button instead of watching the video. Just keep the old "Pop out" and take them to the documentation page for firefox? It is also not worthwhile to spending engineering effort on this as Firefox is less than 1% of our use base.

@jwunderl
Copy link
Member Author

Yeah, I'd prefer to just leave it as linking out to md page vs injecting a gif; in addition to time constraints also think we'd want more troubleshooting info (e.g. how to reenable the feature if it's off in settings for whatever reason, instructions that can be read for accessibility, potential contrast issues, confusion from a gif just popping up instead of what they expected)

@kiki-lee
Copy link
Contributor

I'm kind of worried that the pop-out markdown would cause more trouble than the video. Even with the button, they're probably pretty likely to click that full-screen icon.

This is a tough one,

@abchatra abchatra merged commit 7ef8a60 into master Jan 19, 2023
@abchatra abchatra deleted the addHelpLinkForPoppingOutVideoFirefox branch January 19, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants