-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video Tutorial Issue (Pretty Big) - "Pop Out" button is gone, replaced by faint icon over video #5490
Comments
I can't reproduce this problem. Can you share a gif or video? I can see the popout button clearly in /beta or live. |
The button is toggled on whether the feature is available in that browser or not - details here https://caniuse.com/?search=picture%20in%20picture from the screenshot the icon seems to be the same as the one firefox lists here https://support.mozilla.org/en-US/kb/about-picture-picture-firefox which would make sense, as they choose not to make the api available for websites & provide the feature with the icon you're pointing out -- maybe when we do the feature detection we could add a browser check & if in firefox make the button point at a |
Oh, you're right. My bad. I had switched to Firefox when I was playing with that. Great catch, @jwunderl! |
I put up microsoft/pxt#9298 real quick which would replace the button with a 'gimme help' button on firefox that links to a docs page in case we want that since it was so quick to do |
Can't actually pop out videos at all anymore now that we're using YouTube. Closing in favor of #6560 |
Describe the bug
Video tutorial used to have a "pop out" button that was nice and clear, now it has a faint icon on rollover that is very not clear.
Additionally, there's a full screen icon that is more prominent, but when the user clicks it, it takes 100% of the screen real-estate, making it impossible to code along.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
It should be very clear that users can pop-out the video at a reasonably larger size
Additional context
Using Edge for Mac
The text was updated successfully, but these errors were encountered: