Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Tutorial Issue (Pretty Big) - "Pop Out" button is gone, replaced by faint icon over video #5490

Closed
kiki-lee opened this issue Jan 11, 2023 · 5 comments

Comments

@kiki-lee
Copy link
Contributor

Describe the bug
Firefox - Microsoft MakeCode Arcade 2023-01-11 at 1 06 56 PM

Video tutorial used to have a "pop out" button that was nice and clear, now it has a faint icon on rollover that is very not clear.

Firefox - Microsoft MakeCode Arcade 2023-01-11 at 1 11 38 PM

Additionally, there's a full screen icon that is more prominent, but when the user clicks it, it takes 100% of the screen real-estate, making it impossible to code along.

To Reproduce
Steps to reproduce the behavior:

  1. Go to aka.ms/targets
  2. Play the video
  3. Attempt to pop-out the video without making it full screen
  4. See error

Expected behavior
It should be very clear that users can pop-out the video at a reasonably larger size

Additional context
Using Edge for Mac

@abchatra
Copy link
Collaborator

I can't reproduce this problem. Can you share a gif or video? I can see the popout button clearly in /beta or live.

@jwunderl
Copy link
Member

The button is toggled on whether the feature is available in that browser or not - details here https://caniuse.com/?search=picture%20in%20picture

from the screenshot the icon seems to be the same as the one firefox lists here https://support.mozilla.org/en-US/kb/about-picture-picture-firefox which would make sense, as they choose not to make the api available for websites & provide the feature with the icon you're pointing out -- maybe when we do the feature detection we could add a browser check & if in firefox make the button point at a /firefox-picture-in-picture help page that just says 'click this icon'

@kiki-lee
Copy link
Contributor Author

Oh, you're right. My bad. I had switched to Firefox when I was playing with that. Great catch, @jwunderl!

@jwunderl
Copy link
Member

jwunderl commented Jan 18, 2023

I put up microsoft/pxt#9298 real quick which would replace the button with a 'gimme help' button on firefox that links to a docs page in case we want that since it was so quick to do

@kiki-lee
Copy link
Contributor Author

Can't actually pop out videos at all anymore now that we're using YouTube. Closing in favor of #6560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants