Iconograpy page tag buttons #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the icon name is already at the top of the pane, remove this to get vertical space so the tags can be visible by default.
3 tasks
niels9001
requested changes
Dec 15, 2024
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
marcelwgn
pushed a commit
that referenced
this pull request
Jan 12, 2025
<!--- Provide a general summary of your changes in the Title above --> ## Description This update adds tags to the icons listed in `IconsData.json`, improving the searchability of icons on the iconography page. The only change is the addition of tags to the `IconsData.json` file. **How the Tags Were Chosen:** - For many icons, the tags are derived from those used in the [Fluent UI System Icons](https://github.com/microsoft/fluentui-system-icons.git) project, particularly for common icons. - For most icons and icons that not included in the Fluent UI System Icons, tags were added through a combination of personal effort and assistance from AI. ## Motivation and Context - Many icons currently lack tags, limiting the effectiveness of this feature. Adding tags to all icons ensures that the search functionality is fully utilized, making it easier for users to find the icons they need efficiently. This enhancement aligns with the goal of providing a seamless and user-friendly experience. - Closes #1705 - Related to #1544, #1562 and #1693 ## How Has This Been Tested? **Manually tested** ## Screenshots   ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change)
niels9001
approved these changes
Jan 12, 2025
marcelwgn
reviewed
Jan 12, 2025
| <ItemsView.ItemTemplate> | ||
| <DataTemplate x:DataType="x:String"> | ||
| <ItemContainer> | ||
| <Button Content="{x:Bind Mode=OneWay}" Click="TagButton_Click" /> |
There was a problem hiding this comment.
I think we should provide a fitting UIA name here to indicate what this button does (imagine what the "..." button is supposed to do).
…text Co-authored-by: Marcel W. <[email protected]>
|
/azp run |
3 tasks
niels9001
pushed a commit
that referenced
this pull request
Jan 13, 2025
…1724) ## Description This PR includes the following updates to improve the clarity and conciseness of the icon details: 1. **Remove Unicode Point from Icon Details**: The `unicode point` has been removed, as it adds redundancy without offering additional value. The primary ways to use font icons (`text glyph` in XAML and `code glyph` in C#) are already displayed. 2. **Remove Duplicate Icon Name**: Eliminates the repeated display of the icon name within the icon details, streamlining the information presented. ## Motivation and Context - This change is required to streamline the icon details for clarity and conciseness, especially with #1693 on the way. - Closes #1722 ## How Has This Been Tested? **Manually tested** ## Screenshots (if appropriate):  ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add "tag" buttons to the icon details pane on the "Iconography" page. When the "tag" button is clicked, the "tag" will be set to the icon search box to filter icons by the "tag" text.
This PR will also update the placeholder on the icon search box to "Search icons by name, code, tags...".
Motivation and Context
How Has This Been Tested?
Tested on VS.
Screenshots (if appropriate):
Types of changes