Skip to content

Commit

Permalink
Remove the unicode point & the duplicate icon name from icon details (#…
Browse files Browse the repository at this point in the history
…1724)

## Description
This PR includes the following updates to improve the clarity and
conciseness of the icon details:
1. **Remove Unicode Point from Icon Details**: The `unicode point` has
been removed, as it adds redundancy without offering additional value.
The primary ways to use font icons (`text glyph` in XAML and `code
glyph` in C#) are already displayed.
2. **Remove Duplicate Icon Name**: Eliminates the repeated display of
the icon name within the icon details, streamlining the information
presented.

## Motivation and Context
- This change is required to streamline the icon details for clarity and
conciseness, especially with #1693 on the way.
- Closes #1722 

## How Has This Been Tested?
**Manually tested**

## Screenshots (if appropriate):

![image](https://github.com/user-attachments/assets/69f6fe64-aaa1-4717-b83b-1e02c5638260)

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
  • Loading branch information
Zakariathr22 authored Jan 13, 2025
1 parent 5e92dc1 commit 82893c4
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions WinUIGallery/ControlPages/DesignGuidance/IconographyPage.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -186,20 +186,16 @@
BorderThickness="1,0,0,0"
DataContext="{x:Bind}">
<StackPanel>
<TextBlock
VerticalAlignment="Center"
Style="{StaticResource SubtitleTextBlockStyle}"
Text="{Binding SelectedItem.Name, Mode=OneWay}" />
<FontIcon
Margin="0,12,0,12"
Margin="0,12,0,24"
HorizontalAlignment="Left"
VerticalAlignment="Center"
FontFamily="{StaticResource SymbolThemeFontFamily}"
FontSize="{x:Bind (x:Double)FontsizeComboBox.SelectedValue, Mode=OneWay}"
Glyph="{Binding SelectedItem.Character, Mode=OneWay}" />

<TextBlock Text="Unicode point" />
<controls:SampleCodePresenter Code="{Binding SelectedItem.Code, Mode=OneWay}" Style="{StaticResource CodeValuePresenterStyle}" />
<TextBlock Text="Icon name" />
<controls:SampleCodePresenter Code="{Binding SelectedItem.Name, Mode=OneWay}" Style="{StaticResource CodeValuePresenterStyle}" />
<TextBlock Text="Text glyph" />
<controls:SampleCodePresenter Code="{Binding SelectedItem.TextGlyph, Mode=OneWay}" Style="{StaticResource CodeValuePresenterStyle}" />
<TextBlock Text="Code glyph" />
Expand Down

0 comments on commit 82893c4

Please sign in to comment.