Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CommandBar in PageHeader #1692

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Jay-o-Way
Copy link
Contributor

@Jay-o-Way Jay-o-Way commented Dec 11, 2024

Description

This PR shows the use of a CommandBar in the PageHeader, to accommodate several buttons. It includes @niels9001 his new button for "About API", and I also started to add a Share button, that's supposed to open the OS Share window (ShowShareUIForWindow). The idea is that this can replace the CopyLinkButton. However, at the moment this is not functioning yet, because the (example*) code assumes this CS to be in MainWindow.xaml.cs and it uses a this keyword that doesn't work in the current place. #needhelp

Code example from https://learn.microsoft.com/windows/apps/develop/ui-input/display-ui-objects#for-classes-that-implement-idatatransfermanagerinterop

// Retrieve the window handle (HWND) of the current WinUI 3 window.
var hWnd = WinRT.Interop.WindowNative.GetWindowHandle(this);

Tasks

Preview Give feedback

Motivation and Context

This is a nice demonstration of a CommandBar. It is also adaptive in terms of width, so can't have any issues regarding size.
Issues:

Note: Incompatible with PR #1679

How Has This Been Tested?

Locally.

Screenshots (if appropriate):

CommandBar

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in UX

@Jay-o-Way Jay-o-Way force-pushed the Page-Header-with-CommandBar branch from 71a30dd to 0a1bfda Compare December 11, 2024 14:45
@Jay-o-Way Jay-o-Way force-pushed the Page-Header-with-CommandBar branch from 0a1bfda to f2ff047 Compare December 11, 2024 19:23
@Jay-o-Way Jay-o-Way force-pushed the Page-Header-with-CommandBar branch from a259a65 to e9fa837 Compare December 11, 2024 21:10
@marcelwgn marcelwgn self-requested a review December 12, 2024 21:07
@niels9001
Copy link
Contributor

Hey @Jay-o-Way

Thank you for taking the time to create and submit your PR. We’ve carefully reviewed it, and while we appreciate the effort, we’ve decided not to proceed with it in its current form.

Here's our thinking:

  • The current UI was intentionally designed by our design team to align with a standardized UX across our developer-focused Gallery applications (e.g., AI Dev Gallery, Windows Community Toolkit Gallery).
  • The proposed changes provide limited functional value and introduce an additional click in some cases, which could reduce the discoverability of certain features.

We value the effort you’ve put into this contribution, but for future submissions involving significant UX changes, we should discuss the concept in an issue first. This ensures we can collaborate on the best possible solution and are aligned on the direction. That will avoid unnecessary development work.

@Jay-o-Way
Copy link
Contributor Author

Jay-o-Way commented Dec 14, 2024

We’ve carefully reviewed it

Why is that review not public? I would like to see that.

  • The current UI was intentionally designed by our design team to align with a standardized UX across our developer-focused Gallery applications (e.g., AI Dev Gallery, Windows Community Toolkit Gallery).

Those apps are different already. Not a strong argument to me.

  • The proposed changes provide limited functional value and introduce an additional click in some cases, which could reduce the discoverability of certain features.

I would assume a developer would know to find these buttons. Especially one who used the app before. Note that this is still a work in progress, it's easy to change - like, moving more buttons out of the SecondaryCommands part.

We value the effort you’ve put into this contribution, but for future submissions involving significant UX changes, we should discuss the concept in an issue first. This ensures we can collaborate on the best possible solution and are aligned on the direction.

Now this is where I just get angry. You know very well I've been trying to draw attention to that issue for nine months and it has had no response at all! You all ignored it (and therefore me) and telling me this now is hypocritical and insulting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants