Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Pageheader improvements #1679

Merged
merged 9 commits into from
Dec 12, 2024
Merged

[UX] Pageheader improvements #1679

merged 9 commits into from
Dec 12, 2024

Conversation

niels9001
Copy link
Contributor

@niels9001 niels9001 commented Dec 6, 2024 •
edited
Loading

image

This PR moves the Namespace and Inheritance information in a flyout.

Closes #1678

@marcelwgn
Copy link
Contributor

The button looks a bit off-center to me, it should probably be centered vertically to the main text run right?

@Jay-o-Way
Copy link
Contributor

Jay-o-Way commented Dec 6, 2024 •
edited
Loading

A number of these are empty. Would be pretty to hide the pop-up or better the button in this case.

@niels9001
Copy link
Contributor Author

The button looks a bit off-center to me, it should probably be centered vertically to the main text run right?

Fixed it, it's now properly bottom aligned (text rendering and alignment is so much fun 😁)

@niels9001
Copy link
Contributor Author

A number of these are empty. Would be pretty to hide the pop-up or better the button in this case.

Great catch! That's being handled now, so the i button no longer appears when there is no Namespace and BaseClasses

@niels9001 niels9001 requested a review from marcelwgn December 6, 2024 15:27
@niels9001 niels9001 requested a review from Jay-o-Way December 6, 2024 15:43
@niels9001 niels9001 mentioned this pull request Dec 6, 2024
Open
3 tasks
@niels9001
Copy link
Contributor Author

/azp run

@marcelwgn
Copy link
Contributor

Is it just me or does the icon still look off center? 😅
Screenshot of header and offcenter button

@Jay-o-Way Jay-o-Way mentioned this pull request Dec 11, 2024
Draft
4 tasks
@niels9001
Copy link
Contributor Author

Is it just me or does the icon still look off center? 😅 Screenshot of header and offcenter button

Pushed a small change. Should be bottom-aligned now!

image

@marcelwgn
Copy link
Contributor

/azp run

@marcelwgn marcelwgn merged commit 77635ee into main Dec 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jay-o-Way Jay-o-Way Jay-o-Way left review comments

@marcelwgn marcelwgn marcelwgn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Declutter page header
3 participants
@niels9001 @marcelwgn @Jay-o-Way