add Dockerfile #30
Open
add Dockerfile #30
+132
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitplane
force-pushed
the
docker
branch
2 times, most recently
from
3f7fc6c to
fd81a7f
Compare
|
Nothing to do with my day job, no conflict of interest or IP claims - all my own sweat and tears @microsoft-github-policy-service agree |
bitplane
force-pushed
the
docker
branch
4 times, most recently
from
caae392 to
ea2c291
Compare
Add a post-build script that runs the first time you execute it on a machine with a GPU, since some stuff won't build in the builder Changed app.py to serve on 0.0.0.0, 'cause otherwise we can't expose the ports
AnotiaWang
reviewed
Dec 12, 2024
Dockerfile
Outdated
| # git and build-essential are needed for post_install.sh script. | ||
| # vim and strace are useful for debugging, remove those if you want to. | ||
| RUN apt update && \ | ||
| apt upgrade && \ |
There was a problem hiding this comment.
Maybe missing a -y option here in apt upgrade? Otherwise docker will fail:
Need to get xxxMB of archives.
After this operation, xxxMB of additional disk space will be used.
Do you want to continue? [Y/n] Abort.
ERROR: failed to solve: process "/bin/sh -c apt upgrade" did not complete successfully: exit code: 1
There was a problem hiding this comment.
oof! Yes I added this without testing it. You wouldn't believe how many times I've rebuilt this image! Thanks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Dockerfile, a script to start it on the machine, and a post-build script that runs the first time you execute it on a machine with a GPU (some things won't build without CUDA in the builder, which is currently unsupported by buildx)