Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Docker headless version #48

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

snowzurfer
Copy link

A headless version of the app as a Docker image, so that it can be deployed and used as an endpoint.

I've adapted the Dockerfile from #30, and integrated the fix for the FlexiCubes issue from #34 (comment)

@snowzurfer
Copy link
Author

@microsoft-github-policy-service agree

@bitplane
Copy link

I've made some updates to the Dockerfile in my fork, shuffled stuff around and made it a bit quicker to rebuild. Should we collaborate on a fork and then do a pull request that's more robust? Seems we have a bit of overlap in how we want to use it, and it'll be harder for the team to merge if we diverge

@snowzurfer
Copy link
Author

@bitplane let's do it, and perhaps, what we could do is:

  • we use yours to land a dockerfile for the Gradio-based app, not to create a headless version
  • I point my PR to your branch for that, and build off of that

so that we chain it this way:

  1. your PR: lands a dockerfile that dockerizes what the authors had built, and that's it
  2. my PR: extends yours to add the headless version

it will also enable reviewing the changes more effectively and keep the changes separate logically,

thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants