Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make all pipelines use new agent pools in eastus2 #23072

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/pipelines/build-build-tools.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ extends:
- test:copyresults
taskLint: true
taskLintName: ci:eslint
poolBuild: NewLarge-linux-1ES
poolBuild: Large-centralus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason we had to use the 1ES node pool to begin with? Just double checking we're good to move off of them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're actually not moving off them, the new ones are 1ES pools, I just dropped that bit from the name since we don't really need to differentiate between 1ES and non-1ES ones. We can run all pipelines on 1ES pools, whether they leverage 1ES templates or not.

checkoutSubmodules: true
taskBundleAnalysis: false
checks:
Expand Down
2 changes: 1 addition & 1 deletion tools/pipelines/build-bundle-size-artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ extends:
tagName: bundle-and-code-coverage-artifacts
# This pipeline doesn't generate production artifacts but the build-npm-package template is too intertwined with
# that scenario, which requires that the pipeline runs in the 1ES pool.
poolBuild: NewLarge-linux-1ES
poolBuild: Large-centralus
checkoutSubmodules: true
releaseBuildOverride: none
publishOverride: default
2 changes: 1 addition & 1 deletion tools/pipelines/build-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ extends:
buildDirectory: .
tagName: client
isReleaseGroup: true
poolBuild: NewLarge-linux-1ES
poolBuild: Large-centralus
checkoutSubmodules: true
taskBundleAnalysis: true
taskLint: false # Linting is captured by `ci:build` via fluid-build
Expand Down
16 changes: 8 additions & 8 deletions tools/pipelines/build-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ stages:
- job: debug_variables
displayName: Show Variables
dependsOn: [] # run in parallel
pool: Small
pool: Small-centralus
steps:
- checkout: none
- script: |
Expand All @@ -121,7 +121,7 @@ stages:
- job: component_detection
displayName: Component Detection
dependsOn: [] # run in parallel
pool: Small
pool: Small-centralus
steps:
- task: ComponentGovernanceComponentDetection@0
displayName: Component Detection
Expand All @@ -135,7 +135,7 @@ stages:
displayName: 'Combine api-extractor JSON'
dependsOn: [] # run in parallel
environment: 'fluid-docs-env'
pool: Large
pool: Large-centralus
strategy:
runOnce:
deploy:
Expand All @@ -148,7 +148,7 @@ stages:
- job: build_site
displayName: 'Build website'
dependsOn: upload_json
pool: Large
pool: Large-centralus
steps:
- checkout: self
submodules: false
Expand Down Expand Up @@ -194,7 +194,7 @@ stages:
- stage: guardian
displayName: Guardian
dependsOn: [] # run in parallel
pool: Large
pool: Large-centralus
jobs:
- job: guardian_tasks
displayName: Guardian tasks
Expand Down Expand Up @@ -256,7 +256,7 @@ stages:
- stage: link_check
displayName: 'Website Link Check'
dependsOn: [] # run in parallel
pool: Large
pool: Large-centralus
jobs:
- job: link_check
displayName: 'Website Link Check'
Expand Down Expand Up @@ -297,7 +297,7 @@ stages:

- stage: check_branch_version
displayName: 'Check Version Deployment Condition'
pool: Small
pool: Small-centralus
jobs:
- job: check_branch_version
displayName: 'Check Version Deployment Condition'
Expand Down Expand Up @@ -329,7 +329,7 @@ stages:

- stage: deploy
displayName: 'Deploy website'
pool: Small
pool: Small-centralus
dependsOn: ['build', 'guardian', 'check_branch_version']
variables:
deployOverrideVar: ${{ parameters.deployOverride }}
Expand Down
2 changes: 1 addition & 1 deletion tools/pipelines/repo-policy-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ extends:
template: v1/M365.Unofficial.PipelineTemplate.yml@m365Pipelines
parameters:
pool:
name: Small-1ES # This is one of the Fluid Orgs new 1ES hosted pools.
name: Small-centralus
os: linux
sdl:
${{ if eq(variables['System.TeamProject'], 'internal') }}:
Expand Down
2 changes: 1 addition & 1 deletion tools/pipelines/server-routerlicious.yml
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ extends:
packageManager: pnpm
tagName: server
isReleaseGroup: true
pool: NewLarge-linux-1ES
pool: Large-centralus
pack: true
lint: true
test: ci:test
Expand Down
2 changes: 1 addition & 1 deletion tools/pipelines/templates/build-docker-service.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ parameters:

- name: pool
type: string
default: Small-1ES
default: Small-centralus

- name: buildToolsVersionToInstall
type: string
Expand Down
4 changes: 2 additions & 2 deletions tools/pipelines/templates/build-npm-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ parameters:

- name: poolBuild
type: object
default: Small-1ES
default: Small-centralus

- name: preCG
type: stepList
Expand Down Expand Up @@ -679,7 +679,7 @@ extends:
jobs:
- job: upload_run_telemetry
displayName: Upload pipeline run telemetry to Kusto
pool: Small-1ES
pool: Small-centralus
variables:
- group: ado-feeds
- name: pipelineTelemetryWorkdir
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ parameters:

- name: pool
type: object
default: Small
default: Small-centralus

# The supported values are: short, normal, long
- name: stressMode
Expand All @@ -36,7 +36,7 @@ parameters:
stages:
- stage: CheckAffectedPaths
displayName: Determine changed packages
pool: Small
pool: Small-centralus
jobs:
- job: Job
displayName: Check for DDS package changes
Expand Down
2 changes: 1 addition & 1 deletion tools/pipelines/templates/include-policy-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ stages:
- stage: run_checks
dependsOn: [] # Has no prereqs
displayName: Policy checks
pool: Small-1ES
pool: Small-centralus
jobs:
- job:
displayName: Run checks
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ parameters:

- name: pool
type: object
default: Small-1ES
default: Small-centralus

- name: containerRegistry
type: string
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ parameters:

- name: pool
type: object
default: Small-1ES
default: Small-centralus

- name: publishFlags
type: string
Expand Down
2 changes: 1 addition & 1 deletion tools/pipelines/templates/include-publish-npm-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ parameters:

- name: pool
type: object
default: Small-1ES
default: Small-centralus

- name: isReleaseGroup
type: boolean
Expand Down
2 changes: 1 addition & 1 deletion tools/pipelines/templates/include-test-real-service.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ parameters:

- name: poolBuild
type: object
default: Small
default: Small-centralus

- name: testPackage
type: string
Expand Down
2 changes: 1 addition & 1 deletion tools/pipelines/templates/include-test-stability.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ parameters:

- name: poolBuild
type: object
default: Large
default: Large-centralus

- name: checkoutSubmodules
type: boolean
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ stages:
jobs:
- job: upload_run_telemetry
displayName: Upload stage telemetry to Kusto
pool: Small
pool: Small-centralus
variables:
- group: ado-feeds

Expand Down
2 changes: 1 addition & 1 deletion tools/pipelines/test-perf-benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ parameters:

- name: poolBuild
type: object
default: Large
default: Large-centralus

- name: memoryTestPackages
type: object
Expand Down
10 changes: 5 additions & 5 deletions tools/pipelines/test-real-service-stress.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ stages:
parameters:
stageId: stress_tests_odsp
stageDisplayName: Stress tests - Odsp
poolBuild: Large
poolBuild: Large-centralus
testPackage: ${{ variables.testPackage }}
testWorkspace: ${{ variables.testWorkspace }}
artifactBuildId: $(resources.pipeline.client.runID)
Expand All @@ -65,7 +65,7 @@ stages:
parameters:
stageId: stress_tests_odspdf
stageDisplayName: Stress tests - Odspdf
poolBuild: Large
poolBuild: Large-centralus
testPackage: ${{ variables.testPackage }}
testWorkspace: ${{ variables.testWorkspace }}
artifactBuildId: $(resources.pipeline.client.runID)
Expand All @@ -86,7 +86,7 @@ stages:
parameters:
stageId: stress_tests_tinylicious
stageDisplayName: Stress tests - tinylicious
poolBuild: Large
poolBuild: Large-centralus
testPackage: ${{ variables.testPackage }}
testWorkspace: ${{ variables.testWorkspace }}
artifactBuildId: $(resources.pipeline.client.runID)
Expand All @@ -106,7 +106,7 @@ stages:
parameters:
stageId: stress_tests_frs
stageDisplayName: Stress tests - frs
poolBuild: Large
poolBuild: Large-centralus
testPackage: ${{ variables.testPackage }}
testWorkspace: ${{ variables.testWorkspace }}
artifactBuildId: $(resources.pipeline.client.runID)
Expand All @@ -126,7 +126,7 @@ stages:
parameters:
stageId: stress_tests_frs_canary
stageDisplayName: Stress tests - frs canary
poolBuild: Large
poolBuild: Large-centralus
testPackage: ${{ variables.testPackage }}
testWorkspace: ${{ variables.testWorkspace }}
artifactBuildId: $(resources.pipeline.client.runID)
Expand Down
10 changes: 5 additions & 5 deletions tools/pipelines/test-real-service.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ stages:
parameters:
stageId: e2e_local_server
stageDisplayName: e2e - local server
poolBuild: NewLarge-linux-1ES # Need Large pool for full-compat matrix
poolBuild: Large-centralus # Need Large pool for full-compat matrix
testPackage: ${{ variables.testPackage }}
testWorkspace: ${{ variables.testWorkspace }}
artifactBuildId: $(resources.pipeline.client.runID)
Expand All @@ -61,7 +61,7 @@ stages:
parameters:
stageId: e2e_tinylicious
stageDisplayName: e2e - tinylicious
poolBuild: Large # Need Large pool for full-compat matrix
poolBuild: Large-centralus # Need Large pool for full-compat matrix
testPackage: ${{ variables.testPackage }}
testWorkspace: ${{ variables.testWorkspace }}
artifactBuildId: $(resources.pipeline.client.runID)
Expand All @@ -83,7 +83,7 @@ stages:
parameters:
stageId: e2e_routerlicious
stageDisplayName: e2e - routerlicious
poolBuild: Small
poolBuild: Small-centralus
testPackage: ${{ variables.testPackage }}
testWorkspace: ${{ variables.testWorkspace }}
artifactBuildId: $(resources.pipeline.client.runID)
Expand Down Expand Up @@ -114,7 +114,7 @@ stages:
parameters:
stageId: e2e_frs
stageDisplayName: e2e - frs
poolBuild: Small
poolBuild: Small-centralus
testPackage: ${{ variables.testPackage }}
testWorkspace: ${{ variables.testWorkspace }}
artifactBuildId: $(resources.pipeline.client.runID)
Expand Down Expand Up @@ -146,7 +146,7 @@ stages:
parameters:
stageId: e2e_odsp
stageDisplayName: e2e - odsp
poolBuild: Small
poolBuild: Small-centralus
testPackage: ${{ variables.testPackage }}
testWorkspace: ${{ variables.testWorkspace }}
artifactBuildId: $(resources.pipeline.client.runID)
Expand Down
6 changes: 3 additions & 3 deletions tools/pipelines/test-service-clients.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ stages:
parameters:
stageId: e2e_azure_client_frs
stageDisplayName: e2e - azure client with frs
poolBuild: Small
poolBuild: Small-centralus
testPackage: ${{ variables.testPackage }}
testWorkspace: ${{ variables.testWorkspace }}
testCommand: test:realsvc:azure
Expand All @@ -60,7 +60,7 @@ stages:
parameters:
stageId: e2e_azure_client_local_server
stageDisplayName: e2e - azure client with azure local service
poolBuild: Small
poolBuild: Small-centralus
testPackage: ${{ variables.testPackage }}
testWorkspace: ${{ variables.testWorkspace }}
testCommand: test:realsvc:tinylicious
Expand All @@ -77,7 +77,7 @@ stages:
parameters:
stageId: e2e_odsp_client_odsp_server
stageDisplayName: e2e - odsp client with odsp service
poolBuild: Small
poolBuild: Small-centralus
testPackage: ${{ variables.testOdspPackage }}
testWorkspace: ${{ variables.testWorkspace }}
testCommand: test:realsvc:odsp:run
Expand Down
2 changes: 1 addition & 1 deletion tools/pipelines/test-stability.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ pr: none
parameters:
- name: poolBuild
type: object
default: Large
default: Large-centralus

- name: stageNames
type: object
Expand Down
Loading