-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Make all pipelines use new agent pools in eastus2 #23072
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: aa2718b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 21 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- tools/pipelines/templates/include-conditionally-run-stress-tests.yml: Evaluated as low risk
- tools/pipelines/build-client.yml: Evaluated as low risk
- tools/pipelines/test-real-service.yml: Evaluated as low risk
- tools/pipelines/repo-policy-check.yml: Evaluated as low risk
- tools/pipelines/templates/build-npm-package.yml: Evaluated as low risk
- tools/pipelines/templates/include-upload-stage-telemetry.yml: Evaluated as low risk
- tools/pipelines/test-service-clients.yml: Evaluated as low risk
- tools/pipelines/templates/include-test-real-service.yml: Evaluated as low risk
- tools/pipelines/templates/include-policy-check.yml: Evaluated as low risk
- tools/pipelines/test-real-service-stress.yml: Evaluated as low risk
- tools/pipelines/templates/build-docker-service.yml: Evaluated as low risk
- tools/pipelines/templates/include-publish-npm-package-deployment.yml: Evaluated as low risk
- tools/pipelines/templates/include-test-stability.yml: Evaluated as low risk
- tools/pipelines/test-perf-benchmarks.yml: Evaluated as low risk
- tools/pipelines/templates/include-publish-docker-service-steps.yml: Evaluated as low risk
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Do we expect any perf or latency impact? |
No, with the exception of the e2e tests against routerlicious. Since our internal routerlicious deployment stays in westus2, there's now a longer network path from the agents where the tests run, and the service they're talking to. ~10min runtime increase for that particular stage of the e2e tests. However, I have some design/proposal in the works to get rid of that environment entirely in the short(ish) term, and the increase is not that huge, so I think it's acceptable. I'll also note it's a bit funny that in the 2 runs I've done in the new pools, the r11s tests seems to have fewer failures/timeouts 🤷 .
|
@@ -114,7 +114,7 @@ extends: | |||
- test:copyresults | |||
taskLint: true | |||
taskLintName: ci:eslint | |||
poolBuild: NewLarge-linux-1ES | |||
poolBuild: Large-centralus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the reason we had to use the 1ES node pool to begin with? Just double checking we're good to move off of them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're actually not moving off them, the new ones are 1ES pools, I just dropped that bit from the name since we don't really need to differentiate between 1ES and non-1ES ones. We can run all pipelines on 1ES pools, whether they leverage 1ES templates or not.
Description
We're moving our agent pools to the eastus2 region as part of a capacity management initiative. This PR updates all pipelines to use the new pools.
Reviewer Guidance
The review process is outlined on this wiki page.
I did manual runs of all pipelines with these changes applied, and they all run fine. Failures in test pipelines are unrelated to this change, just the usual flaky tests & similar. And
build-docs
is not designed to run from test/ branches so its failure is also expected.AB#23299