Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shopify] Shpfy Order Transaction: removed Access Internal #24426

Merged
merged 3 commits into from
Aug 30, 2023
Merged

[Shopify] Shpfy Order Transaction: removed Access Internal #24426

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5397ded
Shpfy Order Transaction: removed Access Internal
edenisss Aug 14, 2023
bcf6e7e
Merge branch 'microsoft:main' into DenisErmakov/main
edenisss Aug 15, 2023
5519197
Set Access Internal on CreditCard specific fields
edenisss Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Apps/W1/Shopify/app/src/Transactions/Tables/ShpfyOrderTransaction.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
/// </summary>
table 30133 "Shpfy Order Transaction"
{
Access = Internal;
Caption = 'Shopify Order Transaction';
DataClassification = SystemMetadata;
LookupPageID = "Shpfy Order Transactions";
Expand Down Expand Up @@ -87,30 +86,35 @@ table 30133 "Shpfy Order Transaction"
Caption = 'Source Name';
DataClassification = SystemMetadata;
Editable = false;
Access = Internal;
}
field(16; "Credit Card Bin"; Code[10])
{
Caption = 'Credit Card Bin';
DataClassification = SystemMetadata;
Editable = false;
Access = Internal;
}
field(17; "AVS Result Code"; Code[1])
{
Caption = 'AVS Result Code'; //http://www.emsecommerce.net/avs_cvv2_response_codes.htm
DataClassification = SystemMetadata;
Editable = false;
Access = Internal;
}
field(18; "CVV Result Code"; Code[1])
{
Caption = 'CVV Result Code'; //http://www.emsecommerce.net/avs_cvv2_response_codes.htm
DataClassification = SystemMetadata;
Editable = false;
Access = Internal;
}
field(19; "Credit Card Number"; Text[30])
{
Caption = 'Credit Card Number';
DataClassification = SystemMetadata;
Editable = false;
Access = Internal;
}
field(20; "Credit Card Company"; Text[50])
{
Expand All @@ -137,7 +141,6 @@ table 30133 "Shpfy Order Transaction"
FieldClass = FlowField;
CalcFormula = lookup("Sales Header"."No." where("Shpfy Order Id" = field("Shopify Order Id")));
}

field(102; "Posted Invoice No."; Code[20])
{
Caption = 'Posted Invoice No.';
Expand Down Expand Up @@ -190,7 +193,7 @@ table 30133 "Shpfy Order Transaction"
DataCapture.SetCurrentKey("Linked To Table", "Linked To Id");
DataCapture.SetRange("Linked To Table", Database::"Shpfy Order Transaction");
DataCapture.SetRange("Linked To Id", Rec.SystemId);
if not DataCapture.IsEmpty then
if not DataCapture.IsEmpty() then
DataCapture.DeleteAll(false);
end;
}
Expand Down
Loading