Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shopify] Shpfy Order Transaction: removed Access Internal #24426

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

edenisss
Copy link
Contributor

@edenisss edenisss commented Aug 14, 2023

Hi,

For Paypal transactions (indeed anything other than the standard Shopify Gateway) we need to get access to the Authorization field which is currently sat on “Shpfy Order Transaction", however this table is flagged as Internal.
Basically we drop this on to the External Document No. field in a Sales Order to enable it to flow through to the Bank Ledger Entries.
The change will allow to access the data directly from the table.

Since the table contains sensitive information a list of fields marked as Internal:
field(15; "Source Name"; Code[20])
field(16; "Credit Card Bin"; Code[10])
field(17; "AVS Result Code"; Code[1])
field(18; "CVV Result Code"; Code[1])
field(19; "Credit Card Number"; Text[30])

@edenisss edenisss changed the title Shpfy Order Transaction: removed Access Internal [Shopify] Shpfy Order Transaction: removed Access Internal Aug 14, 2023
@AndreiPanko AndreiPanko added the processing-PR The PR is currently being reviewed label Aug 29, 2023
@JesperSchulz JesperSchulz merged commit 24798db into microsoft:main Aug 30, 2023
6 checks passed
@JesperSchulz
Copy link
Contributor

Will release with 2023 Wave 2.

@JesperSchulz JesperSchulz added the ships-in-future-update Fix ships in a future update label Aug 30, 2023
@JesperSchulz
Copy link
Contributor

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Build ID: 12039.

aholstrup1 pushed a commit to aholstrup1/ALAppExtensions that referenced this pull request Sep 6, 2024
…#24426)

Hi,

For Paypal transactions (indeed anything other than the standard Shopify
Gateway) we need to get access to the Authorization field which is
currently sat on “Shpfy Order Transaction", however this table is
flagged as Internal.
Basically we drop this on to the External Document No. field in a Sales
Order to enable it to flow through to the Bank Ledger Entries.
The change will allow to access the data directly from the table.

Since the table contains sensitive information a list of fields marked
as Internal:
        field(15; "Source Name"; Code[20])
        field(16; "Credit Card Bin"; Code[10])
        field(17; "AVS Result Code"; Code[1])
        field(18; "CVV Result Code"; Code[1])
        field(19; "Credit Card Number"; Text[30])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processing-PR The PR is currently being reviewed ships-in-future-update Fix ships in a future update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants