Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rails path mutation #122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Rails path mutation #122

wants to merge 2 commits into from

Commits on Jul 27, 2016

  1. Fix Rails path mutation 

    ActionDispatch will mutate the uri of a request before the application
actually gets a chance to see it. This can lead to auth failures where
the client signed with the original version of the path, and the server
is comparing against a mutated version.

Instead for ActionDispatch::Request we should use #original_fullpath,
which is passed to Rails from Rack.
    @packrat386
    packrat386 committed Jul 27, 2016
    Configuration menu
    Copy the full SHA
    cfc7bd7 View commit details
    Browse the repository at this point in the history

  2. Fall back to #fullpath 

    Some versions of Rails (notably 3.0) don't have #originl_fullpath, so we
have to fall back to #fullpath.
    @packrat386
    packrat386 committed Jul 27, 2016
    Configuration menu
    Copy the full SHA
    79176e3 View commit details
    Browse the repository at this point in the history