Fix Rails path mutation #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActionDispatch will mutate the uri of a request before the application actually gets a chance to see it. This can lead to auth failures where the client signed with the original version of the path, and the server is comparing against a mutated version. Instead for ActionDispatch::Request we should use #original_fullpath, which is passed to Rails from Rack.
Some versions of Rails (notably 3.0) don't have #originl_fullpath, so we have to fall back to #fullpath.
|
Can you write a spec that can get run through all the request drivers to proves we maintain the trailing slash in each implementation of #request_uri |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionDispatch will mutate the uri of a request before the application
actually gets a chance to see it. This can lead to auth failures where
the client signed with the original version of the path, and the server
is comparing against a mutated version.
Instead for ActionDispatch::Request we should use #original_fullpath,
which is passed to Rails from Rack.