Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#9213): fixes back button navigation after logout #9723

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

latin-panda
Copy link
Contributor

@latin-panda latin-panda commented Dec 23, 2024

Description

I tried a bunch of events (beforeunload, popstate, etc), but none prevented the navigation in Angular v1.
Cleaning the history was what worked the best in Chrome and Firefox. It's not perfect, but significant improvement.

Test video: Back button navigation in Chrome and Firefox
Screen.Recording.2024-12-23.at.1.29.55.PM.mp4

#9213

Code review checklist

  • UI/UX backwards compatible: Test it works for the new design (enabled by default). And test it works in the old design, enable can_view_old_navigation permission to see the old design.
  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@latin-panda latin-panda linked an issue Dec 23, 2024 that may be closed by this pull request
@latin-panda latin-panda requested a review from sugat009 December 23, 2024 19:34
@latin-panda
Copy link
Contributor Author

Hi @sugat009, can you please review this tiny PR? 🙏🏼

@latin-panda latin-panda merged commit 41c4246 into master Dec 24, 2024
46 checks passed
@latin-panda latin-panda deleted the fix-back-button-on-logout branch December 24, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin app allows navigating back after logout
2 participants