Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin app allows navigating back after logout #9213

Closed
latin-panda opened this issue Jun 26, 2024 · 3 comments · Fixed by #9723
Closed

Admin app allows navigating back after logout #9213

latin-panda opened this issue Jun 26, 2024 · 3 comments · Fixed by #9723
Assignees
@latin-panda
Labels
Affects: 4.6.0 Affects: 4.7.0 Affects: 4.7.1 Affects: 4.7.2 Affects: 4.8.0 Affects: 4.8.1 Affects: 4.9.0 Affects: 4.10.0 Affects: 4.11.0 Affects: 4.12.0 Affects: 4.13.0 Affects: 4.14.0 Affects: 4.15.0 Type: Bug Fix something that isn't working as intended
Milestone
4.16.0

Comments

@latin-panda
Copy link
Contributor

latin-panda commented Jun 26, 2024 •
edited
Loading

Describe the bug
Loads page when pressing back button

To Reproduce
See video

Screen.Recording.2024-06-26.at.1.02.14.PM.mov

Expected behavior
I should not load the page and redirect to login.

Logs
The console log didn't show any error

Environment

  • Instance: EKS
  • Browser: Chrome
  • Client platform: MacOS
  • App: admin
  • Version: 4.6.0

Additional context
We had a similar issue a few years ago, maybe a regression. I couldn't find the issue number.
@latin-panda
Copy link
Contributor Author

@garethbowen is this a patch release? Happening from 4.6 to current

@garethbowen
Copy link
Contributor

To understand the severity of this issue, can you please verify that your session is dead, ie: if you try and navigate to another page it fails?

@latin-panda
Copy link
Contributor Author

I just tried again, after navigating 5-10 secs and triggering a request, it redirected to login page.

@dianabarsan dianabarsan removed the Type: Security Affects security label Nov 27, 2024
@dianabarsan dianabarsan changed the title Navigation after logout Admin app allows navigating back after logout Nov 27, 2024
@latin-panda latin-panda mentioned this issue Dec 23, 2024
Merged
6 tasks
@latin-panda latin-panda added this to the 4.16.0 milestone Dec 23, 2024
@latin-panda latin-panda linked a pull request Dec 23, 2024 that will close this issue
fix(#9213): fixes back button navigation after logout #9723
Merged
6 tasks
@latin-panda latin-panda self-assigned this Dec 23, 2024
@latin-panda latin-panda moved this from Todo to In Progress in Product Team Activities Dec 23, 2024
latin-panda added a commit that referenced this issue Dec 24, 2024
@latin-panda
fix(#9213): fixes back button navigation after logout (#9723)
41c4246
@github-project-automation github-project-automation bot moved this from In Progress to Done in Product Team Activities Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@latin-panda latin-panda

Labels
Affects: 4.6.0 Affects: 4.7.0 Affects: 4.7.1 Affects: 4.7.2 Affects: 4.8.0 Affects: 4.8.1 Affects: 4.9.0 Affects: 4.10.0 Affects: 4.11.0 Affects: 4.12.0 Affects: 4.13.0 Affects: 4.14.0 Affects: 4.15.0 Type: Bug Fix something that isn't working as intended
Projects
No open projects
Product Team Activities
Status: Done
Milestone
4.16.0
Development

Successfully merging a pull request may close this issue.

fix(#9213): fixes back button navigation after logout medic/cht-core
8 participants
@garethbowen @Benmuiruri @witash @m5r @lorerod @sugat009 @dianabarsan @latin-panda