chore: Add new fields to elevator widget #44
Conversation
lib/config/v2/elevator.ex
Outdated
| evergreen_content: list(EvergreenContentItem.t()), | ||
| alternate_direction_text: String.t(), | ||
| accessible_path_image_url: String.t(), | ||
| accessible_path_direction_arrow: arrow_direction() |
There was a problem hiding this comment.
Since none of these are nullable and all are enforced when constructing, are we fine with manually updating existing elevator screen configs? Just calling out that we'd have to remember to do this (and either have content ready to go or use "stub" content).
There was a problem hiding this comment.
I can go ahead and stub them out. I think it's important for these to be required in the future because without them, the screens would be mostly blank if the current elevator is closed.
lib/config/v2/elevator.ex
Outdated
| @@ -3,14 +3,23 @@ defmodule ScreensConfig.V2.Elevator do | |||
|
|
|||
| alias ScreensConfig.V2.EvergreenContentItem | |||
|
|
|||
| @type arrow_direction :: :n | :s | :e | :w | |||
There was a problem hiding this comment.
Do we want to support diagonal arrows? There's precedent for this (Sectional header wayfinding), so I don't think it would be that difficult.
There was a problem hiding this comment.
I can ask Betsy that.
There was a problem hiding this comment.
Good call. We want diagonal as well.
There was a problem hiding this comment.
Cool. It would be nice if we could unify the types, then — maybe have a ScreensConfig.Arrow.t() referenced by both. (or maybe it's too early for that)
There was a problem hiding this comment.
Sure. There were a few other configs that supported this type so I changed those as well.
cmaddox5
force-pushed
the
cm/elevator-alternate-direction-config
branch
from
17eb9c7 to
a417acd
Compare
cmaddox5
force-pushed
the
cm/elevator-alternate-direction-config
branch
from
a417acd to
33d67b5
Compare
Adding some new fields that will be needed when building out the "Current elevator closed" view on the widget.