Create new Arrow type for reuse.

mbta · Nov 21, 2024 · a417acd · a417acd
1 parent febe11b
commit a417acd
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 12 deletions.
diff --git a/lib/config/arrow.ex b/lib/config/arrow.ex
@@ -0,0 +1,5 @@
+defmodule ScreensConfig.Arrow do
+  @moduledoc false
+
+  @type t :: :n | :ne | :e | :se | :s | :sw | :w | :nw | nil
+end
diff --git a/lib/config/v2/blue_bikes/station.ex b/lib/config/v2/blue_bikes/station.ex
@@ -1,15 +1,15 @@
 defmodule ScreensConfig.V2.BlueBikes.Station do
   @moduledoc false
 
+  alias ScreensConfig.Arrow
+
   @type t :: %__MODULE__{
           id: String.t(),
-          arrow: arrow(),
+          arrow: Arrow.t(),
           walk_distance_minutes: non_neg_integer(),
           walk_distance_feet: non_neg_integer()
         }
 
-  @type arrow :: :n | :ne | :e | :se | :s | :sw | :w | :nw | nil
-
   @enforce_keys [:id, :arrow, :walk_distance_minutes, :walk_distance_feet]
   defstruct @enforce_keys
 

diff --git a/lib/config/v2/departures/header.ex b/lib/config/v2/departures/header.ex
@@ -11,8 +11,10 @@ defmodule ScreensConfig.V2.Departures.Header do
   If `title` is not set, there is no visual header, but `read_as` is still read out, if set.
   """
 
+  alias ScreensConfig.Arrow
+
   @type t :: %__MODULE__{
-          arrow: nil | :n | :ne | :e | :se | :s | :sw | :w | :nw,
+          arrow: Arrow.t(),
           read_as: String.t() | nil,
           title: String.t() | nil
         }

diff --git a/lib/config/v2/elevator.ex b/lib/config/v2/elevator.ex
@@ -1,16 +1,15 @@
 defmodule ScreensConfig.V2.Elevator do
   @moduledoc false
 
+  alias ScreensConfig.Arrow
   alias ScreensConfig.V2.EvergreenContentItem
 
-  @type arrow_direction :: :n | :s | :e | :w
-
   @type t :: %__MODULE__{
           elevator_id: String.t(),
           evergreen_content: list(EvergreenContentItem.t()),
           alternate_direction_text: String.t(),
           accessible_path_image_url: String.t(),
-          accessible_path_direction_arrow: arrow_direction()
+          accessible_path_direction_arrow: Arrow.t()
         }
 
   @enforce_keys [

diff --git a/lib/config/v2/shuttle_bus_info.ex b/lib/config/v2/shuttle_bus_info.ex
@@ -1,22 +1,20 @@
 defmodule ScreensConfig.V2.ShuttleBusInfo do
   @moduledoc false
 
-  alias ScreensConfig.V2.ShuttleBusSchedule
-  alias ScreensConfig.V2.WidgetInstance
+  alias ScreensConfig.Arrow
+  alias ScreensConfig.V2.{ShuttleBusSchedule, WidgetInstance}
 
   @type t :: %__MODULE__{
           minutes_range_to_destination_schedule: list(ShuttleBusSchedule.t()),
           destination: String.t(),
-          arrow: arrow(),
+          arrow: Arrow.t(),
           english_boarding_instructions: String.t(),
           spanish_boarding_instructions: String.t(),
           audio_boarding_instructions: String.t(),
           priority: WidgetInstance.priority(),
           enabled: boolean()
         }
 
-  @type arrow :: :n | :ne | :e | :se | :s | :sw | :w | :nw | nil
-
   defstruct minutes_range_to_destination_schedule: [],
             destination: nil,
             arrow: nil,