Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Android): parse join responses correctly #598

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

boringcactus
Copy link
Member

Summary

Ticket: 🤖 | Nearby Transit | Initial load jank

I appear to have broken this all the way back in #263.

iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"
      android
  • All user-facing strings added to strings resource

Testing

Manually verified that alerts load when the alerts join response is sent now (and that predictions load when the predictions join response is sent now).

Copy link
Contributor

@JackVCurtis JackVCurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@boringcactus boringcactus merged commit 401ee0c into main Dec 19, 2024
5 checks passed
@boringcactus boringcactus deleted the mth-android-joins-lost branch December 19, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants