fix(Android): minimize issues when updating map global data #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonTR
approved these changes
Dec 19, 2024
KaylaBrady
reviewed
Dec 19, 2024
|
|
||
| @Composable | ||
| override fun rememberGlobalMapData(now: Instant): GlobalMapData? { | ||
| var result by remember { mutableStateOf<GlobalMapData?>(null) } |
There was a problem hiding this comment.
suggestion(non-blocking): For consistency with the refresh functions below, this could update a mutable state property of the VM rather than remembering the result within the function
There was a problem hiding this comment.
I don't think it works the same way as those refresh functions - it's a @Composable called from the UI thread and not a suspend fun called from a LaunchedEffect, and even if I made globalMapData() update some mutable state it'd still need to return the value to avoid uglier code or less up-to-date output of the refresh functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: 🤖 | Nearby Transit | Initial load jank
The acceptance criteria mention this too and I entirely forgot about it when implementing #598 so here it is as a separate PR. More details in the Asana comments.
iOS
android
Testing
Verified that the alerts are correctly drawn as they arrive and that the UI does not hang while the global data is recalculating.