Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): leave / rejoin predictions & alerts after backgrounding #588

Merged
merged 1 commit into from
Dec 17, 2024

feat(android): leave / rejoin predictions & alerts after backgrounding

b5740cd
Select commit
Loading
Failed to load commit list.
Merged

feat(android): leave / rejoin predictions & alerts after backgrounding #588

feat(android): leave / rejoin predictions & alerts after backgrounding
b5740cd
Select commit
Loading
Failed to load commit list.
Xcode Cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS succeeded Dec 17, 2024 in 29m 34s

47 warnings

Report Summary
Errors 0
Test Failures 0
Analysis Issues 0
Warnings 47

Details

47 Warnings

Details

  iosApp/iosApp/Pages/Onboarding/OnboardingScreenView.swift:148
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/Utils/UIWindowExtension.swift:16
      Prefer For-Where Violation: `where` clauses are preferred over a single `if` inside a `for` (for_where)
  iosApp/iosApp/Pages/Onboarding/OnboardingScreenView.swift:81
      Line Length Violation: Line should be 120 characters or less; currently it has 139 characters (line_length)
  iosApp/iosApp/ViewModels/StopDetailsViewModel.swift:9
      Blanket Disable Command Violation: Use 'next', 'this' or 'previous' instead to disable the 'type_body_length' rule once, or re-enable it as soon as possible` (blanket_disable_command)
  iosApp/iosApp/Pages/More/MoreSection.swift:38
      Line Length Violation: Line should be 120 characters or less; currently it has 122 characters (line_length)
  iosApp/iosApp/Pages/Onboarding/OnboardingScreenView.swift:134
      Line Length Violation: Line should be 120 characters or less; currently it has 124 characters (line_length)
  iosApp/iosApp/Fetchers/ViewportProvider.swift:150
      Unused Optional Binding Violation: Prefer `!= nil` over `let _ =` (unused_optional_binding)
  iosApp/iosAppUITests/HomeMapViewUITests.swift:79
      Initialization of immutable value 'springboard' was never used; consider replacing with assignment to '_' or removing it
  iosApp/iosApp/Pages/Onboarding/OnboardingScreenView.swift:144
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/Utils/RouteTypeExtension.swift:23
      Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
  iosApp/iosApp/Pages/Map/MapHttpInterceptor.swift:31
      Immutable value 'error' was never used; consider replacing with '_' or removing it
  iosApp/iosAppTests/Pages/Map/MapViewModelTests.swift:20
      Initialization of immutable value 'mapVM' was never used; consider replacing with assignment to '_' or removing it
  iosApp/iosApp/Pages/Map/MapLayerManager.swift:73
      Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)
  iosApp/iosApp/Pages/More/MoreLink.swift:14
      Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
  iosApp/iosApp/Pages/Map/HomeMapViewHandlerExtension.swift:296
      Todo Violation: TODOs should be resolved (figure out something to do if ...) (todo)
  iosApp/iosAppTests/ViewModels/ErrorBannerViewModelTests.swift:24
      Instance method 'wait' is unavailable from asynchronous contexts; Use await fulfillment(of:timeout:enforceOrder:) instead; this is an error in Swift 6
  iosApp/iosApp/Pages/StopDetails/TripDetailsView.swift:118
      Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 6 (function_parameter_count)
  iosApp/iosApp/Pages/AlertDetails/AlertDetails.swift:31
      Todo Violation: TODOs should be resolved (Add all possible alert effects...) (todo)
  iosApp/iosApp/Pages/Map/AnnotatedMap.swift:35
      'MapContentGestureContext' is deprecated: renamed to 'InteractionContext'
  iosApp/iosApp/Utils/FetchApi.swift:35
      Immutable value 'error' was never used; consider replacing with '_' or removing it
  iosApp/iosApp/ComponentViews/UpcomingTripView.swift:150
      Line Length Violation: Line should be 120 characters or less; currently it has 139 characters (line_length)
  iosApp/iosApp/ComponentViews/SheetNavigationLink.swift:21
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/ViewModels/SettingsViewModel.swift:66
      Line Length Violation: Line should be 120 characters or less; currently it has 150 characters (line_length)
  iosApp/iosAppTests/Views/OptionalNavigationLinkTests.swift:41
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/ProductionAppView.swift:84
      Expression implicitly coerced from 'URLResponse?' to 'Any'
  iosApp/iosApp/ViewModels/SettingsViewModel.swift:92
      Line Length Violation: Line should be 120 characters or less; currently it has 137 characters (line_length)
  iosApp/iosApp/ContentView.swift:360
      Large Tuple Violation: Tuples should have at most 2 members (large_tuple)
  iosApp/iosApp/Pages/LegacyStopDetails/StopDetailsFilterPills.swift:77
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/ComponentViews/LocationAuthButton.swift:85
      Line Length Violation: Line should be 120 characters or less; currently it has 137 characters (line_length)
  iosApp/iosApp/Pages/Map/HomeMapViewHandlerExtension.swift:257
      'MapContentGestureContext' is deprecated: renamed to 'InteractionContext'
  iosApp/iosApp/ComponentViews/ActionButton.swift:78
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/Pages/NearbyTransit/NearbyTransitView.swift:564
      File Length Violation: File should contain 400 lines or less: currently contains 564 (file_length)
  iosApp/iosApp/Pages/Map/HomeMapViewHandlerExtension.swift:166
      Immutable value 'tripFilter' was never used; consider replacing with '_' or removing it
  iosApp/iosApp/Pages/NearbyTransit/NearbyTransitView.swift:17
      Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 315 lines (type_body_length)
  iosApp/iosApp/Utils/RouteTypeExtension.swift:21
      Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
  iosApp/iosApp/ViewModels/SearchViewModel.swift:122
      Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
  iosApp/iosApp/Pages/StopDetails/TripVehicleCard.swift:98
      Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
  iosApp/iosApp/Pages/TripDetails/TripDetailsPage.swift:14
      Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 307 lines (type_body_length)
  iosApp/iosApp/ViewModels/ErrorBannerViewModel.swift:17
      Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
  iosApp/iosApp/ViewModels/SettingsViewModel.swift:100
      Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)
  iosApp/iosAppTests/Pages/NearbyTransit/RouteCardTests.swift:22
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/ViewModels/SettingsViewModel.swift:84
      Line Length Violation: Line should be 120 characters or less; currently it has 124 characters (line_length)
  iosApp/iosApp/ComponentViews/ErrorBanner.swift:56
      Line Length Violation: Line should be 120 characters or less; currently it has 126 characters (line_length)
  iosApp/iosApp/ContentView.swift:7
      Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 342 lines (type_body_length)
  iosApp/iosApp/Pages/NearbyTransit/StopDeparturesSummaryList.swift:38
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/Pages/LegacyStopDetails/StopDetailsFilteredRouteView.swift:221
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/Utils/RouteTypeExtension.swift:18
      Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)