feat(android): leave / rejoin predictions & alerts after backgrounding #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaBrady
commented
Dec 16, 2024
| @@ -98,7 +98,7 @@ fun HomeMapView( | |||
| var railRouteLineData: List<RouteLineData>? by remember { mutableStateOf(null) } | |||
| var stopSourceData: FeatureCollection? by remember { mutableStateOf(null) } | |||
|
|
|||
| val now = timer(updateInterval = 10.seconds) | |||
| val now = timer(updateInterval = 300.seconds) | |||
There was a problem hiding this comment.
I noticed this was causing lag / jankiness and saw the iOS value is 300 seconds, so updated to match.
This can be further improved by moving getAlertsByStop to a background thread for calculation since the calculation alone takes ~1 second. That wasn't straight forward to do within the remember func though, and would probably need to be moved into the ViewModel. I can make a separate ticket for that
EmmaSimon
approved these changes
Dec 16, 2024
| connectToPredictions() | ||
| override fun onCleared() { | ||
| super.onCleared() | ||
| predictionsRepository.disconnect() |
There was a problem hiding this comment.
nitpick: Should this call the vm's disconnect() instead?
3 tasks
KaylaBrady
force-pushed
the
kb-android-backgrounding
branch
from
46dc1ed to
8b36601
Compare
KaylaBrady
force-pushed
the
kb-android-backgrounding-2
branch
from
b2d38b7 to
b5740cd
Compare
|
android-only change, ran iOS app locally and confirmed unaffected. Merging before iOS workflows complete |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: 🤖 | Stability | Leave realtime channels when backgrounding
What is this PR for?
Follow-up to #579, applies the same pattern to predictions & alerts.
iOS
android
Testing
What testing have you done?