Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jv-oop change #2240

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main/java/core/basesyntax/Bulldozer.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package core.basesyntax;

public class Bulldozer extends Mashine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class name Mashine seems to be a typo. It should be Machine according to the task description and checklist.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class name Mashine is likely a typo. It should be Machine according to the task description. Please correct this to ensure consistency and functionality.

@Override
public void doWork() {
System.out.println("Bulldozer почав працювати.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message in doWork() is not in English. The task checklist requires all messages to be in English. Please update this message to be informative and in English.

}
@Override
public void stopWork() {
System.out.println("Bulldozer закінчив працювати.");
Comment on lines +6 to +10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The messages in the doWork and stopWork methods should be in English. Consider changing them to something like "Bulldozer started working." and "Bulldozer stopped working." to meet the checklist requirement of using English and making messages informative.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message in stopWork() is not in English. The task checklist requires all messages to be in English. Please update this message to be informative and in English.

}
}
12 changes: 12 additions & 0 deletions src/main/java/core/basesyntax/Excavator.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package core.basesyntax;

public class Excavator extends Mashine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class name Mashine seems to be a typo. It should be Machine according to the task description and checklist.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class name Mashine is likely a typo. It should be Machine according to the task description. Please correct this to ensure consistency and functionality.

@Override
public void doWork() {
System.out.println("Excavator почав працювати.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message in doWork() is not in English. The task checklist requires all messages to be in English. Please update this message to be informative and in English.

}
@Override
public void stopWork() {
System.out.println("Excavator закінчив працювати.");
Comment on lines +6 to +10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The messages in the doWork and stopWork methods should be in English. Consider changing them to something like "Excavator started working." and "Excavator stopped working." to meet the checklist requirement of using English and making messages informative.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message in stopWork() is not in English. The task checklist requires all messages to be in English. Please update this message to be informative and in English.

}
}
12 changes: 11 additions & 1 deletion src/main/java/core/basesyntax/MainApp.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
package core.basesyntax;

public class MainApp {

public static void main(String[] args) {
Mashine[] mashines = {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class name Mashine is consistently misspelled. It should be Machine. Please correct this typo in the array declaration and throughout the code.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The array type Mashine is likely a typo. It should be Machine to match the corrected class name.

new Truck(),
new Bulldozer(),
new Excavator(),
};
for (Mashine mashine : mashines) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable type Mashine is misspelled. It should be Machine to match the corrected class name.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The loop variable type Mashine is likely a typo. It should be Machine to match the corrected class name.

mashine.doWork();
mashine.stopWork();
}
}
}
6 changes: 6 additions & 0 deletions src/main/java/core/basesyntax/Mashine.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
package core.basesyntax;

public abstract class Mashine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class name Mashine is misspelled. It should be Machine according to the task description and checklist. Please correct this to ensure consistency across the project.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class name Mashine is likely a typo. It should be Machine according to the task description. Please correct this to ensure consistency and functionality.

public abstract void doWork();
public abstract void stopWork();
}
12 changes: 12 additions & 0 deletions src/main/java/core/basesyntax/Truck.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package core.basesyntax;

public class Truck extends Mashine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class name Mashine seems to be a typo. It should be Machine according to the task description and checklist.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class name Mashine is likely a typo. It should be Machine according to the task description. Please correct this to ensure consistency and functionality.

@Override
public void doWork() {
System.out.println("Truck почав працювати.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message in doWork() is not in English. The task checklist requires all messages to be in English. Please update this message to be informative and in English.

}
@Override
public void stopWork() {
System.out.println("Truck закінчив працювати.");
Comment on lines +6 to +10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The messages in the doWork and stopWork methods should be in English. Consider changing them to something like "Truck started working." and "Truck stopped working." to meet the checklist requirement of using English and making messages informative.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message in stopWork() is not in English. The task checklist requires all messages to be in English. Please update this message to be informative and in English.

}
}
Loading