Jv-oop change #2240
Jv-oop change #2240
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 There are a couple of critical issues that need to be addressed before we can approve the pull request:
-
Class Naming Consistency: The class name
Mashineis consistently misspelled throughout your code. According to the task description, it should beMachine. This typo affects the functionality and consistency of your code, so it's important to correct it across all files (Bulldozer.java,Excavator.java,Truck.java, andMainApp.java). -
Language Consistency: The messages in the
doWork()andstopWork()methods are not in English. The task checklist requires that all messages be in English and informative. Please update these messages to ensure they meet the requirements.
Once these issues are resolved, your code will be in great shape! Keep up the great work, and don't hesitate to reach out if you have any questions or need further assistance. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
| @@ -0,0 +1,12 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public class Bulldozer extends Mashine { | |||
There was a problem hiding this comment.
The class name Mashine seems to be a typo. It should be Machine according to the task description and checklist.
| System.out.println("Bulldozer почав працювати."); | ||
| } | ||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Bulldozer закінчив працювати."); |
There was a problem hiding this comment.
The messages in the doWork and stopWork methods should be in English. Consider changing them to something like "Bulldozer started working." and "Bulldozer stopped working." to meet the checklist requirement of using English and making messages informative.
| @@ -0,0 +1,12 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public class Excavator extends Mashine { | |||
There was a problem hiding this comment.
The class name Mashine seems to be a typo. It should be Machine according to the task description and checklist.
| System.out.println("Excavator почав працювати."); | ||
| } | ||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Excavator закінчив працювати."); |
There was a problem hiding this comment.
The messages in the doWork and stopWork methods should be in English. Consider changing them to something like "Excavator started working." and "Excavator stopped working." to meet the checklist requirement of using English and making messages informative.
| @@ -1,5 +1,15 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public class MainApp { | |||
|
|
|||
| public static void main(String[] args) { | |||
| Mashine[] mashines = { | |||
There was a problem hiding this comment.
The class name Mashine is consistently misspelled. It should be Machine. Please correct this typo in the array declaration and throughout the code.
| new Bulldozer(), | ||
| new Excavator(), | ||
| }; | ||
| for (Mashine mashine : mashines) { |
There was a problem hiding this comment.
The variable type Mashine is misspelled. It should be Machine to match the corrected class name.
| @@ -0,0 +1,6 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public abstract class Mashine { | |||
There was a problem hiding this comment.
The class name Mashine is misspelled. It should be Machine according to the task description and checklist. Please correct this to ensure consistency across the project.
| @@ -0,0 +1,12 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public class Truck extends Mashine { | |||
There was a problem hiding this comment.
The class name Mashine seems to be a typo. It should be Machine according to the task description and checklist.
| System.out.println("Truck почав працювати."); | ||
| } | ||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Truck закінчив працювати."); |
There was a problem hiding this comment.
The messages in the doWork and stopWork methods should be in English. Consider changing them to something like "Truck started working." and "Truck stopped working." to meet the checklist requirement of using English and making messages informative.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Thank you for your submission! 🎉 While your code has been approved to help you move forward with your learning journey, there are a few critical issues that need attention:
-
Class Naming Consistency: The class name
Mashineis misspelled and should be corrected toMachineacross all files (Bulldozer.java,Excavator.java,Truck.java,MainApp.java, andMashine.java). This change is crucial for consistency and functionality. -
Language Consistency: The messages in the
doWork()andstopWork()methods are not in English. Please update these messages to be informative and in English, as required by the task checklist.
Please address these issues in future iterations to enhance the quality and functionality of your code. Keep up the good work and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -0,0 +1,12 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public class Bulldozer extends Mashine { | |||
There was a problem hiding this comment.
The class name Mashine is likely a typo. It should be Machine according to the task description. Please correct this to ensure consistency and functionality.
| public class Bulldozer extends Mashine { | ||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Bulldozer почав працювати."); |
There was a problem hiding this comment.
The message in doWork() is not in English. The task checklist requires all messages to be in English. Please update this message to be informative and in English.
| } | ||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Bulldozer закінчив працювати."); |
There was a problem hiding this comment.
The message in stopWork() is not in English. The task checklist requires all messages to be in English. Please update this message to be informative and in English.
| @@ -0,0 +1,12 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public class Excavator extends Mashine { | |||
There was a problem hiding this comment.
The class name Mashine is likely a typo. It should be Machine according to the task description. Please correct this to ensure consistency and functionality.
| public class Excavator extends Mashine { | ||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Excavator почав працювати."); |
There was a problem hiding this comment.
The message in doWork() is not in English. The task checklist requires all messages to be in English. Please update this message to be informative and in English.
| new Bulldozer(), | ||
| new Excavator(), | ||
| }; | ||
| for (Mashine mashine : mashines) { |
There was a problem hiding this comment.
The loop variable type Mashine is likely a typo. It should be Machine to match the corrected class name.
| @@ -0,0 +1,6 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public abstract class Mashine { | |||
There was a problem hiding this comment.
The class name Mashine is likely a typo. It should be Machine according to the task description. Please correct this to ensure consistency and functionality.
| @@ -0,0 +1,12 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public class Truck extends Mashine { | |||
There was a problem hiding this comment.
The class name Mashine is likely a typo. It should be Machine according to the task description. Please correct this to ensure consistency and functionality.
| public class Truck extends Mashine { | ||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Truck почав працювати."); |
There was a problem hiding this comment.
The message in doWork() is not in English. The task checklist requires all messages to be in English. Please update this message to be informative and in English.
| } | ||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Truck закінчив працювати."); |
There was a problem hiding this comment.
The message in stopWork() is not in English. The task checklist requires all messages to be in English. Please update this message to be informative and in English.
No description provided.