Kikongo MT #124
Kikongo MT #124
Conversation
|
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Awesome, great job! 💯
To clean up the files, could you please remove the .ipynb_checkpoints directory from the PR? And the starter_notebook.ipynb, otherwise it will overwrite the default one.
In addition, please upload the best.ckpt for the model on GoogleDrive (or a similar platform), and add the link to the README. This will ensure that others can load and use the model as well. Thank you! ❤️
|
Dear Julia,
Thank you so much for accepting my request. I will take in consideration
all the remarks.
Sincerely yours,
Berthine.
Le ven. 28 août 2020 à 06:15, Julia Kreutzer <[email protected]> a
écrit :
… ***@***.**** requested changes on this pull request.
Awesome, great job! 💯
To clean up the files, could you please remove the .ipynb_checkpoints
directory from the PR? And the starter_notebook.ipynb, otherwise it will
overwrite the default one.
In addition, please upload the best.ckpt for the model on GoogleDrive (or
a similar platform), and add the link to the README. This will ensure that
others can load and use the model as well. Thank you! ❤️
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#124 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK5OFAU57ZNUVXBZH5GQPOLSC5DPLANCNFSM4QI5C3RA>
.
|
|
Done. |
|
Thank you. I will do it.
Le lun. 28 sept. 2020 à 12:56, Julia Kreutzer <[email protected]> a
écrit :
… ***@***.**** requested changes on this pull request.
Looks good! Thank you!
One last thing: please remove the "starter_notebook" from the PR,
otherwise it gets overwritten.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#124 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK5OFAW5YPDZOWH5QMMSDZLSICBYFANCNFSM4QI5C3RA>
.
|
|
Done. |
There was a problem hiding this comment.
Hi @berthine sorry for the misunderstanding, but now your commit would remove the starter_notebooks from the master branch as well. Can you please revert those files? See https://www.git-tower.com/learn/git/faq/restoring-deleted-files/
|
Same for the starter_notebook-custom-data.ipynb. |
|
@berthine ping :) |
Kikongo is one of the language spoken in DRC.