Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up for experimental --pptx-editable in Windows environment #632

Merged
merged 4 commits into from
Jan 19, 2025

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Jan 17, 2025

Follow up for experimental --pptx-editable option (#626), especially Windows environment.

  • Removed Windows LibreOffice app transparency from WSL. WSL-specific finder is no longer used.
    • Tmpfile saved into WSL environment cannot read from Windows LibreOffice.
  • Detect LibreOffice installed via Scoop in Windows. (--pptx-editable option cannot detect LibreOffice installed via Scoop #631)
  • Update error level of soffice stderr from ERROR to WARN.
    • Windows may throw an error about libpng as ERROR, but the conversion would be successful. Showing ERROR level may lead confusion.

- Removed Windows LibreOffice app transparency from WSL.
- WSL-specific finder is no longer used.
- Detect LibreOffice installed via Scoop in Windows. (#631)
- Update error level of soffice stderr from ERROR to WARN.
@yhatt yhatt linked an issue Jan 17, 2025 that may be closed by this pull request
@yhatt yhatt merged commit 9a8e20b into main Jan 19, 2025
1 check passed
@yhatt yhatt deleted the soffice-improvement branch January 19, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--pptx-editable option cannot detect LibreOffice installed via Scoop
1 participant