Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--pptx-editable option cannot detect LibreOffice installed via Scoop #631

Closed
yhatt opened this issue Jan 17, 2025 · 0 comments · Fixed by #632
Closed

--pptx-editable option cannot detect LibreOffice installed via Scoop #631

yhatt opened this issue Jan 17, 2025 · 0 comments · Fixed by #632
Labels
bug Something isn't working

Comments

@yhatt
Copy link
Member

yhatt commented Jan 17, 2025

Version of Marp Tool

Marp CLI v4.1.0

Operating System

Windows

Environment

  • OS version: Windows 11
  • Node.js version: v20.17.0

How to reproduce

  1. Install LibreOffice via scoop install libreoffice
  2. Run marp --pptx-editable --pptx slide.md

Expected behavior

Export PPTX into slide.pptx.

Actual behavior

[ ERROR ] Failed converting Markdown. (LibreOffice soffice binary could not be found.)

Additional information

LibreOffice soffice.exe installed via Scoop will be placed at %UserProfile%\scoop\apps\libreoffice\current\LibreOffice\program.

Probably we have to search the location of LibreOffice from potential directories.

Workaround

Set SOFFICE_PATH env as %UserProfile%\scoop\apps\libreoffice\current\LibreOffice\program\soffice.exe.
@yhatt yhatt added bug-triage May be a bug and needs triage bug Something isn't working and removed bug-triage May be a bug and needs triage labels Jan 17, 2025
yhatt added a commit that referenced this issue Jan 17, 2025
@yhatt
Improve SOffice binary finder and handler
c11e616 
- Removed Windows LibreOffice app transparency from WSL.
- WSL-specific finder is no longer used.
- Detect LibreOffice installed via Scoop in Windows. (#631)
- Update error level of soffice stderr from ERROR to WARN.
@yhatt yhatt mentioned this issue Jan 17, 2025
Merged
@yhatt yhatt linked a pull request Jan 17, 2025 that will close this issue
Follow up for experimental --pptx-editable in Windows environment #632
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Follow up for experimental --pptx-editable in Windows environment marp-team/marp-cli
1 participant
@yhatt