Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release references to native objects when destoy() called #7856

Merged
merged 2 commits into from
Aug 28, 2024

Rename changelog files

58943b8
Select commit
Loading
Failed to load commit list.
Merged

Release references to native objects when destoy() called #7856

Rename changelog files
58943b8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 23, 2024 in 1s

74.10% (-0.08%) compared to 95377ec

View this Pull Request on Codecov

74.10% (-0.08%) compared to 95377ec

Details

Codecov Report

Attention: Patch coverage is 20.87912% with 72 lines in your changes missing coverage. Please review.

Project coverage is 74.10%. Comparing base (95377ec) to head (58943b8).

Files Patch % Lines
...on/navigator/internal/MapboxNativeNavigatorImpl.kt 0.00% 35 Missing ⚠️
...vigation/core/trip/session/eh/RoadObjectMatcher.kt 0.00% 14 Missing ⚠️
...ox/navigation/ui/maps/PredictiveCacheController.kt 50.00% 10 Missing ⚠️
...avigation/core/trip/session/eh/RoadObjectsStore.kt 0.00% 6 Missing ⚠️
...x/navigation/core/trip/session/eh/GraphAccessor.kt 0.00% 5 Missing ⚠️
...ava/com/mapbox/navigation/core/MapboxNavigation.kt 66.66% 0 Missing and 1 partial ⚠️
...box/navigation/core/NavigationComponentProvider.kt 0.00% 1 Missing ⚠️

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #7856      +/-   ##
============================================
- Coverage     74.18%   74.10%   -0.08%     
+ Complexity     6262     6260       -2     
============================================
  Files           856      856              
  Lines         33793    33809      +16     
  Branches       4022     4027       +5     
============================================
- Hits          25068    25053      -15     
- Misses         7169     7199      +30     
- Partials       1556     1557       +1
Files Coverage Δ
...mapbox/navigation/core/internal/PredictiveCache.kt 92.47% <100.00%> (+0.16%) ⬆️
.../navigation/core/trip/session/MapboxTripSession.kt 84.75% <100.00%> (+0.21%) ⬆️
...gation/navigator/internal/MapboxNativeNavigator.kt 0.00% <ø> (ø)
...ava/com/mapbox/navigation/core/MapboxNavigation.kt 72.41% <66.66%> (-0.07%) ⬇️
...box/navigation/core/NavigationComponentProvider.kt 56.00% <0.00%> (ø)
...x/navigation/core/trip/session/eh/GraphAccessor.kt 18.18% <0.00%> (ø)
...avigation/core/trip/session/eh/RoadObjectsStore.kt 6.89% <0.00%> (ø)
...ox/navigation/ui/maps/PredictiveCacheController.kt 58.47% <50.00%> (-14.36%) ⬇️
...vigation/core/trip/session/eh/RoadObjectMatcher.kt 5.30% <0.00%> (ø)
...on/navigator/internal/MapboxNativeNavigatorImpl.kt 0.00% <0.00%> (ø)
View more details on Codecov