-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release references to native objects when destoy() called #7856
Conversation
ChangelogFeatures
Bug fixes and improvements
Known issues
|
* accepts [MapboxNavigation] instance. | ||
* | ||
* @param predictiveCacheOptions [PredictiveCacheOptions] options to instantiate instance of [PredictiveCacheController] | ||
* @throws IllegalStateException if [MapboxNavigation] was not instantiated before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This behavior is not breaking, it just makes crash explicit. In the previous version of this class it would crash in createNavigationController
if MapboxNavigation
was not instantiated.
Now the behavior is clear, we explicitly ask for MapboxNavigation
with which predictive cache will be associated.
* Release references to native objects when destoy() called * Rename changelog files
Description
Release references to native objects when MapboxNavigation.destoy() called
Screenshots or Gifs
TODO