Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAVAND-1564: do not resume route refreshes after routes are changed #7579

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

dzinad
Copy link
Contributor

@dzinad dzinad commented Oct 23, 2023

No description provided.

@dzinad dzinad requested a review from a team as a code owner October 23, 2023 16:41
@github-actions
Copy link

Changelog

Features

Bug fixes and improvements

  • Optimised memory and network usage. [#7555](https://github.com/mapbox/mapbox-navigation-android/pull/7555)
  • Fixed an issue where route refreshes might not have been paused after invoking RouteRefreshController#pauseRouteRefreshes. [#dd](https://github.com/mapbox/mapbox-navigation-android/pull/dd)
  • Fixed an issue when alertcCodes and trafficCodes were lost during route refresh. [#7568](https://github.com/mapbox/mapbox-navigation-android/pull/7568)

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

  • The app is now considered as the one in active navigation only when an active route is set to MapboxNavigation. Previously it was always considered active. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)
  • When Android Auto host tells the app to stop active navigation because another app starts navigating, now SDK will enter FreeDrive mode instead of stopping trip session completely. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #7579 (0fad5c1) into main (a26ec08) will decrease coverage by 0.01%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #7579      +/-   ##
============================================
- Coverage     74.15%   74.15%   -0.01%     
- Complexity     6153     6154       +1     
============================================
  Files           830      830              
  Lines         32936    32936              
  Branches       3930     3933       +3     
============================================
- Hits          24424    24423       -1     
  Misses         6978     6978              
- Partials       1534     1535       +1     
Files Coverage Δ
...core/routerefresh/PlannedRouteRefreshController.kt 99.07% <90.90%> (-0.93%) ⬇️

Copy link
Contributor

@VysotskiVadim VysotskiVadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Do you think it's worth adding this scenario to RouteRefreshIntegrationTest ?

@dzinad dzinad added the needs backporting Requires cherry-picking to a currently running release branch label Oct 25, 2023
@dzinad
Copy link
Contributor Author

dzinad commented Oct 25, 2023

Do you think it's worth adding this scenario to RouteRefreshIntegrationTest ?

There's already such a test:
https://github.com/mapbox/mapbox-navigation-android/pull/7579/files#diff-d88a5958afe5e289be4823457a425faff66120ec36b0b865016d91e39f583594R61

@dzinad dzinad merged commit 116880d into main Oct 25, 2023
3 of 6 checks passed
@dzinad dzinad deleted the NAVAND-1564-dd branch October 25, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs backporting Requires cherry-picking to a currently running release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants